From 14c1f5f1f4503144664bf685a590815ecfd09ca6 Mon Sep 17 00:00:00 2001 From: nicolethoen Date: Wed, 8 Mar 2023 13:49:32 -0500 Subject: [PATCH 1/3] fix(test): update script --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 2dbf1a85774..162d35832e1 100644 --- a/package.json +++ b/package.json @@ -90,7 +90,7 @@ "start:cypress": "lerna run cypress:open", "start:demo-app": "lerna run start:demo-app --stream", "start:demo-app:hot": "lerna run start:demo-app:hot --stream", - "test": "TZ=EST jest packages", + "test": "TZ=EST LC_ALL=en_US.UTF8 jest packages", "test:a11y": "lerna run test:a11y --stream", "test:integration": "yarn workspace @patternfly/react-integration test:integration", "uninstall": "find . -name node_modules -type d | xargs rm -rf", From bb2f5ccd71e701e3d60e6cdadb01170e26b5c03d Mon Sep 17 00:00:00 2001 From: nicolethoen Date: Wed, 8 Mar 2023 15:19:18 -0500 Subject: [PATCH 2/3] update node engine in package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 162d35832e1..9e4b472f057 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "url": "https://github.com/patternfly/patternfly-react.git" }, "engines": { - "node": ">=14.0.0", + "node": ">=18.0.0", "yarn": ">=1.6.0" }, "keywords": [ From 0960b546b2bd369e700135ce584b9d115a5dca06 Mon Sep 17 00:00:00 2001 From: nicolethoen Date: Thu, 9 Mar 2023 09:25:28 -0500 Subject: [PATCH 3/3] update contribution guide --- packages/react-core/CONTRIBUTING.md | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/react-core/CONTRIBUTING.md b/packages/react-core/CONTRIBUTING.md index 848b86bcb5d..70270504f64 100644 --- a/packages/react-core/CONTRIBUTING.md +++ b/packages/react-core/CONTRIBUTING.md @@ -62,7 +62,18 @@ $ git checkout -b my-branch -t upstream/main ComponentName.md - Component Docs ``` -4. Develop your component. After development is complete, ensure tests and lint standards pass. +4. Develop your component. + +While developing, you can run the patternfly-react workspace to view the component docs with live examples. + +**Note:** Be sure you are using node version >= 18.0.0 + +```bash +# Start up the workspace locally on port 8002 + yarn install && yarn start +``` + +5. After development is complete, ensure tests and lint standards pass. ```text $ yarn test