chore(deps): Bump core version #8830
Conversation
|
Preview: https://patternfly-react-pr-8830.surge.sh A11y report: https://patternfly-react-pr-8830-a11y.surge.sh |
| </Popover> | ||
| {helperText && <div className={styles.datePickerHelperText}>{helperText}</div>} | ||
| {errorText.trim() && <div className={css(styles.datePickerHelperText, styles.modifiers.error)}>{errorText}</div>} | ||
| {errorText.trim() && <div className={css(styles.datePickerHelperText)}>{errorText}</div>} |
There was a problem hiding this comment.
Won't this cause error to be unstyled (or styled the same way as helper)?
There was a problem hiding this comment.
looks like it is also causing cypress to fail as it tries to find div.pf-m-error
https://github.com/patternfly/patternfly-react/blob/v5/packages/react-integration/cypress/integration/datepicker.spec.ts#L17
if removing error styling is intended, could update cypress to look for pf-c-date-picker__helper-text assuming there is no helper text
There was a problem hiding this comment.
There is a follow up issue for the helper text work
There was a problem hiding this comment.
I disabled the test for now. It should be reenabled with the datePicker helper text work (I left a note in the issue). This PR is just to bump the core version and get it to build so we have the styles to address the feature work once this goes in
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
4 participants
closes: #8831
Bump core version