From 02714a1ed830203233eeb2e26a9722d80e269ec6 Mon Sep 17 00:00:00 2001 From: Titani Date: Fri, 17 Mar 2023 15:48:49 -0400 Subject: [PATCH 1/3] chore(deps): Bump core version --- packages/react-core/package.json | 2 +- .../react-core/src/components/DatePicker/DatePicker.tsx | 2 +- .../react-core/src/components/TimePicker/TimePicker.tsx | 2 +- packages/react-docs/package.json | 2 +- packages/react-icons/package.json | 2 +- packages/react-styles/package.json | 2 +- .../react-table/src/components/TableComposable/Td.tsx | 2 +- .../react-table/src/components/TableComposable/Th.tsx | 2 +- packages/react-tokens/package.json | 2 +- yarn.lock | 8 ++++---- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/react-core/package.json b/packages/react-core/package.json index 34281eeed69..74bf640c8ce 100644 --- a/packages/react-core/package.json +++ b/packages/react-core/package.json @@ -53,7 +53,7 @@ "tslib": "^2.0.0" }, "devDependencies": { - "@patternfly/patternfly": "5.0.0-alpha.24", + "@patternfly/patternfly": "5.0.0-alpha.33", "@rollup/plugin-commonjs": "^24.0.0", "@rollup/plugin-node-resolve": "^15.0.1", "@rollup/plugin-replace": "^5.0.2", diff --git a/packages/react-core/src/components/DatePicker/DatePicker.tsx b/packages/react-core/src/components/DatePicker/DatePicker.tsx index 7b068d06fa7..b043f429366 100644 --- a/packages/react-core/src/components/DatePicker/DatePicker.tsx +++ b/packages/react-core/src/components/DatePicker/DatePicker.tsx @@ -272,7 +272,7 @@ const DatePickerBase = ( {helperText &&
{helperText}
} - {errorText.trim() &&
{errorText}
} + {errorText.trim() &&
{errorText}
} ); }; diff --git a/packages/react-core/src/components/TimePicker/TimePicker.tsx b/packages/react-core/src/components/TimePicker/TimePicker.tsx index dd014267a1e..ed680a6152b 100644 --- a/packages/react-core/src/components/TimePicker/TimePicker.tsx +++ b/packages/react-core/src/components/TimePicker/TimePicker.tsx @@ -538,7 +538,7 @@ export class TimePicker extends React.Component {isInvalid && ( -
+
{!isValidFormat ? invalidFormatErrorMessage : invalidMinMaxErrorMessage}
)} diff --git a/packages/react-docs/package.json b/packages/react-docs/package.json index cabbec71a81..0634b318b78 100644 --- a/packages/react-docs/package.json +++ b/packages/react-docs/package.json @@ -23,7 +23,7 @@ "test:a11y": "patternfly-a11y --config patternfly-a11y.config" }, "dependencies": { - "@patternfly/patternfly": "5.0.0-alpha.24", + "@patternfly/patternfly": "5.0.0-alpha.33", "@patternfly/react-charts": "^7.0.0-alpha.11", "@patternfly/react-code-editor": "^5.0.0-alpha.38", "@patternfly/react-core": "^5.0.0-alpha.38", diff --git a/packages/react-icons/package.json b/packages/react-icons/package.json index 57fc5c4640a..16f70fa9fde 100644 --- a/packages/react-icons/package.json +++ b/packages/react-icons/package.json @@ -32,7 +32,7 @@ "@fortawesome/free-brands-svg-icons": "^5.14.0", "@fortawesome/free-regular-svg-icons": "^5.14.0", "@fortawesome/free-solid-svg-icons": "^5.14.0", - "@patternfly/patternfly": "5.0.0-alpha.24", + "@patternfly/patternfly": "5.0.0-alpha.33", "fs-extra": "^11.1.0", "glob": "^7.1.2", "rimraf": "^2.6.2", diff --git a/packages/react-styles/package.json b/packages/react-styles/package.json index 37b3ada8f1c..e4fb7db33e2 100644 --- a/packages/react-styles/package.json +++ b/packages/react-styles/package.json @@ -19,7 +19,7 @@ "clean": "rimraf dist css" }, "devDependencies": { - "@patternfly/patternfly": "5.0.0-alpha.24", + "@patternfly/patternfly": "5.0.0-alpha.33", "camel-case": "^3.0.0", "css": "^2.2.3", "fs-extra": "^6.0.1", diff --git a/packages/react-table/src/components/TableComposable/Td.tsx b/packages/react-table/src/components/TableComposable/Td.tsx index f38a586966c..0c02f5295b2 100644 --- a/packages/react-table/src/components/TableComposable/Td.tsx +++ b/packages/react-table/src/components/TableComposable/Td.tsx @@ -255,7 +255,7 @@ const TdBase: React.FunctionComponent = ({ isActionCell && styles.tableAction, textCenter && styles.modifiers.center, noPadding && styles.modifiers.noPadding, - isStickyColumn && scrollStyles.tableStickyColumn, + isStickyColumn && scrollStyles.tableStickyCell, // further updates will be made with issue #8829 hasRightBorder && scrollStyles.modifiers.borderRight, styles.modifiers[modifier as 'breakWord' | 'fitContent' | 'nowrap' | 'truncate' | 'wrap' | undefined], draggableParams && styles.tableDraggable, diff --git a/packages/react-table/src/components/TableComposable/Th.tsx b/packages/react-table/src/components/TableComposable/Th.tsx index 8b768c6da1f..00dd88bae7f 100644 --- a/packages/react-table/src/components/TableComposable/Th.tsx +++ b/packages/react-table/src/components/TableComposable/Th.tsx @@ -170,7 +170,7 @@ const ThBase: React.FunctionComponent = ({ className, textCenter && styles.modifiers.center, isSubheader && styles.tableSubhead, - isStickyColumn && scrollStyles.tableStickyColumn, + isStickyColumn && scrollStyles.tableStickyCell, // further updates will be made with issue #8829 hasRightBorder && scrollStyles.modifiers.borderRight, modifier && styles.modifiers[modifier as 'breakWord' | 'fitContent' | 'nowrap' | 'truncate' | 'wrap'], mergedClassName diff --git a/packages/react-tokens/package.json b/packages/react-tokens/package.json index ac8198b9d05..d10ee8c151b 100644 --- a/packages/react-tokens/package.json +++ b/packages/react-tokens/package.json @@ -29,7 +29,7 @@ "clean": "rimraf dist" }, "devDependencies": { - "@patternfly/patternfly": "5.0.0-alpha.24", + "@patternfly/patternfly": "5.0.0-alpha.33", "css": "^2.2.3", "fs-extra": "^6.0.1", "glob": "^7.1.2", diff --git a/yarn.lock b/yarn.lock index 55ad11a9bce..aafcbe67122 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3961,10 +3961,10 @@ puppeteer-cluster "^0.23.0" xmldoc "^1.1.2" -"@patternfly/patternfly@5.0.0-alpha.24": - version "5.0.0-alpha.24" - resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-5.0.0-alpha.24.tgz#8f5c49cd7cd0ff82fc207a9e155748671ccdfd08" - integrity sha512-A3jR7clHikVh30tSCN2FKP/7UXywJ1Jo1B9ntO/9nqU1Q7k6v549UXeWWTcHPAALUN5KVduTkvMg6VWX7jB6tA== +"@patternfly/patternfly@5.0.0-alpha.33": + version "5.0.0-alpha.33" + resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-5.0.0-alpha.33.tgz#3f3a2d6b10fbfb75f1a44e5f4c7e0df9265a4691" + integrity sha512-UV+kRiKuBPH0bHKXaKi2QVMqdcQxMVaQxl6TB++4fEeUgDnOsmRq8kG5WPD6fvfVYvs3DEE9oYo7C6922vFPvQ== "@phenomnomnominal/tsquery@4.1.1": version "4.1.1" From 6c4316f894e5bee8c9f78eb8ad4701ec708cc965 Mon Sep 17 00:00:00 2001 From: Titani Date: Fri, 17 Mar 2023 16:25:24 -0400 Subject: [PATCH 2/3] disable failing test case --- packages/react-core/src/components/DatePicker/DatePicker.tsx | 1 + .../react-integration/cypress/integration/datepicker.spec.ts | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/react-core/src/components/DatePicker/DatePicker.tsx b/packages/react-core/src/components/DatePicker/DatePicker.tsx index b043f429366..f699f5c5631 100644 --- a/packages/react-core/src/components/DatePicker/DatePicker.tsx +++ b/packages/react-core/src/components/DatePicker/DatePicker.tsx @@ -260,6 +260,7 @@ const DatePickerBase = ( />