Skip to content

chore(deps): Bump core version #8830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 3 commits into from
Mar 18, 2023
Merged

chore(deps): Bump core version #8830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02714a1
chore(deps): Bump core version
Mar 17, 2023
6c4316f
disable failing test case
Mar 17, 2023
3cf1469
disable test
Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"tslib": "^2.0.0"
},
"devDependencies": {
"@patternfly/patternfly": "5.0.0-alpha.24",
"@patternfly/patternfly": "5.0.0-alpha.33",
"@rollup/plugin-commonjs": "^24.0.0",
"@rollup/plugin-node-resolve": "^15.0.1",
"@rollup/plugin-replace": "^5.0.2",
Expand Down
3 changes: 2 additions & 1 deletion packages/react-core/src/components/DatePicker/DatePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ const DatePickerBase = (
/>
<button
ref={buttonRef}
// TODO: Removed style follow up work with issue #8457
className={css(buttonStyles.button, buttonStyles.modifiers.control)}
aria-label={buttonAriaLabel}
type="button"
Expand All @@ -272,7 +273,7 @@ const DatePickerBase = (
</div>
</Popover>
{helperText && <div className={styles.datePickerHelperText}>{helperText}</div>}
{errorText.trim() && <div className={css(styles.datePickerHelperText, styles.modifiers.error)}>{errorText}</div>}
{errorText.trim() && <div className={css(styles.datePickerHelperText)}>{errorText}</div>}
Copy link
Contributor

@gitdallas gitdallas Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this cause error to be unstyled (or styled the same way as helper)?

Copy link
Contributor

@gitdallas gitdallas Mar 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

looks like it is also causing cypress to fail as it tries to find div.pf-m-error
https://github.com/patternfly/patternfly-react/blob/v5/packages/react-integration/cypress/integration/datepicker.spec.ts#L17

if removing error styling is intended, could update cypress to look for pf-c-date-picker__helper-text assuming there is no helper text

Copy link
Contributor Author

@tlabaj tlabaj Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a follow up issue for the helper text work

Copy link
Contributor Author

@tlabaj tlabaj Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled the test for now. It should be reenabled with the datePicker helper text work (I left a note in the issue). This PR is just to bump the core version and get it to build so we have the styles to address the feature work once this goes in

</div>
);
};
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/TimePicker/TimePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ export class TimePicker extends React.Component<TimePickerProps, TimePickerState
</div>
</InputGroup>
{isInvalid && (
<div className={css(datePickerStyles.datePickerHelperText, datePickerStyles.modifiers.error)}>
<div className={css(datePickerStyles.datePickerHelperText)}>
{!isValidFormat ? invalidFormatErrorMessage : invalidMinMaxErrorMessage}
</div>
)}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"test:a11y": "patternfly-a11y --config patternfly-a11y.config"
},
"dependencies": {
"@patternfly/patternfly": "5.0.0-alpha.24",
"@patternfly/patternfly": "5.0.0-alpha.33",
"@patternfly/react-charts": "^7.0.0-alpha.11",
"@patternfly/react-code-editor": "^5.0.0-alpha.38",
"@patternfly/react-core": "^5.0.0-alpha.38",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-icons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@fortawesome/free-brands-svg-icons": "^5.14.0",
"@fortawesome/free-regular-svg-icons": "^5.14.0",
"@fortawesome/free-solid-svg-icons": "^5.14.0",
"@patternfly/patternfly": "5.0.0-alpha.24",
"@patternfly/patternfly": "5.0.0-alpha.33",
"fs-extra": "^11.1.0",
"glob": "^7.1.2",
"rimraf": "^2.6.2",
Expand Down
3 changes: 2 additions & 1 deletion packages/react-integration/cypress/integration/datepicker.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ it('Navigate to demo section', () => {
cy.visit('http://localhost:3000/date-picker-demo-nav-link');
});

it('Verify validation error can be cleared from outside', () => {
// TODO: Reenable with issue #8457
xit('Verify validation error can be cleared from outside', () => {
cy.get('.pf-c-date-picker')
.children()
.within(() => {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-styles/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"clean": "rimraf dist css"
},
"devDependencies": {
"@patternfly/patternfly": "5.0.0-alpha.24",
"@patternfly/patternfly": "5.0.0-alpha.33",
"camel-case": "^3.0.0",
"css": "^2.2.3",
"fs-extra": "^6.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-table/src/components/TableComposable/Td.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ const TdBase: React.FunctionComponent<TdProps> = ({
isActionCell && styles.tableAction,
textCenter && styles.modifiers.center,
noPadding && styles.modifiers.noPadding,
isStickyColumn && scrollStyles.tableStickyColumn,
isStickyColumn && scrollStyles.tableStickyCell, // TODO: further updates will be made with issue #8829
hasRightBorder && scrollStyles.modifiers.borderRight,
styles.modifiers[modifier as 'breakWord' | 'fitContent' | 'nowrap' | 'truncate' | 'wrap' | undefined],
draggableParams && styles.tableDraggable,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-table/src/components/TableComposable/Th.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ const ThBase: React.FunctionComponent<ThProps> = ({
className,
textCenter && styles.modifiers.center,
isSubheader && styles.tableSubhead,
isStickyColumn && scrollStyles.tableStickyColumn,
isStickyColumn && scrollStyles.tableStickyCell, // TODO: further updates will be made with issue #8829
hasRightBorder && scrollStyles.modifiers.borderRight,
modifier && styles.modifiers[modifier as 'breakWord' | 'fitContent' | 'nowrap' | 'truncate' | 'wrap'],
mergedClassName
Expand Down
2 changes: 1 addition & 1 deletion packages/react-tokens/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"clean": "rimraf dist"
},
"devDependencies": {
"@patternfly/patternfly": "5.0.0-alpha.24",
"@patternfly/patternfly": "5.0.0-alpha.33",
"css": "^2.2.3",
"fs-extra": "^6.0.1",
"glob": "^7.1.2",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3961,10 +3961,10 @@
puppeteer-cluster "^0.23.0"
xmldoc "^1.1.2"

"@patternfly/patternfly@5.0.0-alpha.24":
version "5.0.0-alpha.24"
resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-5.0.0-alpha.24.tgz#8f5c49cd7cd0ff82fc207a9e155748671ccdfd08"
integrity sha512-A3jR7clHikVh30tSCN2FKP/7UXywJ1Jo1B9ntO/9nqU1Q7k6v549UXeWWTcHPAALUN5KVduTkvMg6VWX7jB6tA==
"@patternfly/patternfly@5.0.0-alpha.33":
version "5.0.0-alpha.33"
resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-5.0.0-alpha.33.tgz#3f3a2d6b10fbfb75f1a44e5f4c7e0df9265a4691"
integrity sha512-UV+kRiKuBPH0bHKXaKi2QVMqdcQxMVaQxl6TB++4fEeUgDnOsmRq8kG5WPD6fvfVYvs3DEE9oYo7C6922vFPvQ==

"@phenomnomnominal/tsquery@4.1.1":
version "4.1.1"
Expand Down