From c02c72d054c8f8589ecad4633b319bcb0a730283 Mon Sep 17 00:00:00 2001
From: Mohammed Saud <md.saud020@gmail.com>
Date: Wed, 29 Mar 2023 18:04:40 +0530
Subject: [PATCH] fix(Wizard): add type to nav item buttons

---
 .../src/components/Wizard/WizardNavItem.tsx         |  3 ++-
 .../__snapshots__/WizardNavItem.test.tsx.snap       |  1 +
 .../__tests__/__snapshots__/Wizard.test.tsx.snap    | 13 +++++++++++++
 3 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/packages/react-core/src/components/Wizard/WizardNavItem.tsx b/packages/react-core/src/components/Wizard/WizardNavItem.tsx
index 6b60bd24371..42dcbd6eba6 100644
--- a/packages/react-core/src/components/Wizard/WizardNavItem.tsx
+++ b/packages/react-core/src/components/Wizard/WizardNavItem.tsx
@@ -57,7 +57,8 @@ export const WizardNavItem: React.FunctionComponent<WizardNavItemProps> = ({
   }
 
   const btnProps = {
-    disabled: isDisabled
+    disabled: isDisabled,
+    type: 'button' as const
   };
 
   const linkProps = {
diff --git a/packages/react-core/src/components/Wizard/__tests__/Generated/__snapshots__/WizardNavItem.test.tsx.snap b/packages/react-core/src/components/Wizard/__tests__/Generated/__snapshots__/WizardNavItem.test.tsx.snap
index 57e852dba30..f00d3a101aa 100644
--- a/packages/react-core/src/components/Wizard/__tests__/Generated/__snapshots__/WizardNavItem.test.tsx.snap
+++ b/packages/react-core/src/components/Wizard/__tests__/Generated/__snapshots__/WizardNavItem.test.tsx.snap
@@ -11,6 +11,7 @@ exports[`WizardNavItem should match snapshot (auto-generated) 1`] = `
       data-ouia-component-id="OUIA-Generated-WizardNavItem-1"
       data-ouia-component-type="PF4/WizardNavItem"
       data-ouia-safe="true"
+      type="button"
     />
     ReactNode
   </li>
diff --git a/packages/react-core/src/components/Wizard/__tests__/__snapshots__/Wizard.test.tsx.snap b/packages/react-core/src/components/Wizard/__tests__/__snapshots__/Wizard.test.tsx.snap
index ebc96024807..35c7fd7db70 100644
--- a/packages/react-core/src/components/Wizard/__tests__/__snapshots__/Wizard.test.tsx.snap
+++ b/packages/react-core/src/components/Wizard/__tests__/__snapshots__/Wizard.test.tsx.snap
@@ -111,6 +111,7 @@ exports[`Wizard Expandable Nav Wizard should match snapshot 1`] = `
                 data-ouia-component-id="OUIA-Generated-WizardNavItem-7"
                 data-ouia-component-type="PF4/WizardNavItem"
                 data-ouia-safe="true"
+                type="button"
               >
                 A
               </button>
@@ -125,6 +126,7 @@ exports[`Wizard Expandable Nav Wizard should match snapshot 1`] = `
                 data-ouia-component-id="OUIA-Generated-WizardNavItem-8"
                 data-ouia-component-type="PF4/WizardNavItem"
                 data-ouia-safe="true"
+                type="button"
               >
                 <span
                   class="pf-c-wizard__nav-link-text"
@@ -166,6 +168,7 @@ exports[`Wizard Expandable Nav Wizard should match snapshot 1`] = `
                     data-ouia-component-id="OUIA-Generated-WizardNavItem-9"
                     data-ouia-component-type="PF4/WizardNavItem"
                     data-ouia-safe="true"
+                    type="button"
                   >
                     B-1
                   </button>
@@ -179,6 +182,7 @@ exports[`Wizard Expandable Nav Wizard should match snapshot 1`] = `
                     data-ouia-component-id="OUIA-Generated-WizardNavItem-10"
                     data-ouia-component-type="PF4/WizardNavItem"
                     data-ouia-safe="true"
+                    type="button"
                   >
                     B-2
                   </button>
@@ -194,6 +198,7 @@ exports[`Wizard Expandable Nav Wizard should match snapshot 1`] = `
                 data-ouia-component-id="OUIA-Generated-WizardNavItem-11"
                 data-ouia-component-type="PF4/WizardNavItem"
                 data-ouia-safe="true"
+                type="button"
               >
                 C
               </button>
@@ -207,6 +212,7 @@ exports[`Wizard Expandable Nav Wizard should match snapshot 1`] = `
                 data-ouia-component-id="OUIA-Generated-WizardNavItem-12"
                 data-ouia-component-type="PF4/WizardNavItem"
                 data-ouia-safe="true"
+                type="button"
               >
                 D
               </button>
@@ -381,6 +387,7 @@ exports[`Wizard Wizard should match snapshot 1`] = `
                 data-ouia-component-type="PF4/WizardNavItem"
                 data-ouia-safe="true"
                 id="step-A"
+                type="button"
               >
                 A
               </button>
@@ -395,6 +402,7 @@ exports[`Wizard Wizard should match snapshot 1`] = `
                 data-ouia-component-type="PF4/WizardNavItem"
                 data-ouia-safe="true"
                 id="step-B"
+                type="button"
               >
                 B
               </button>
@@ -412,6 +420,7 @@ exports[`Wizard Wizard should match snapshot 1`] = `
                     data-ouia-component-type="PF4/WizardNavItem"
                     data-ouia-safe="true"
                     id="step-B-1"
+                    type="button"
                   >
                     B-1
                   </button>
@@ -426,6 +435,7 @@ exports[`Wizard Wizard should match snapshot 1`] = `
                     data-ouia-component-type="PF4/WizardNavItem"
                     data-ouia-safe="true"
                     id="step-B-2"
+                    type="button"
                   >
                     B-2
                   </button>
@@ -442,6 +452,7 @@ exports[`Wizard Wizard should match snapshot 1`] = `
                 data-ouia-component-type="PF4/WizardNavItem"
                 data-ouia-safe="true"
                 id="step-C"
+                type="button"
               >
                 C
               </button>
@@ -456,6 +467,7 @@ exports[`Wizard Wizard should match snapshot 1`] = `
                 data-ouia-component-type="PF4/WizardNavItem"
                 data-ouia-safe="true"
                 id="step-D"
+                type="button"
               >
                 D
               </button>
@@ -586,6 +598,7 @@ exports[`Wizard bare wiz 1`] = `
                 data-ouia-component-id="OUIA-Generated-WizardNavItem-13"
                 data-ouia-component-type="PF4/WizardNavItem"
                 data-ouia-safe="true"
+                type="button"
               >
                 A
               </button>