Skip to content

chore(NavExpandable): Change e to event in onExpand #8897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2023
Merged

chore(NavExpandable): Change e to event in onExpand #8897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/react-core/src/components/Nav/NavExpandable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export interface NavExpandableProps
/** Identifier to use for the section aria label */
id?: string;
/** allow consumer to optionally override this callback and manage expand state externally. if passed will not call Nav's onToggle. */
onExpand?: (e: React.MouseEvent<HTMLButtonElement, MouseEvent>, val: boolean) => void;
onExpand?: (event: React.MouseEvent<HTMLButtonElement, MouseEvent>, val: boolean) => void;
/** Additional props added to the NavExpandable <button> */
buttonProps?: any;
/** Value to overwrite the randomly generated data-ouia-component-id.*/
Expand Down Expand Up @@ -71,7 +71,7 @@ export class NavExpandable extends React.Component<NavExpandableProps, NavExpand
}

onExpand = (
e: React.MouseEvent<HTMLButtonElement, MouseEvent>,
event: React.MouseEvent<HTMLButtonElement, MouseEvent>,
onToggle: (
event: React.MouseEvent<HTMLButtonElement, MouseEvent>,
groupId: string | number,
Expand All @@ -80,11 +80,11 @@ export class NavExpandable extends React.Component<NavExpandableProps, NavExpand
) => {
const { expandedState } = this.state;
if (this.props.onExpand) {
this.props.onExpand(e, !expandedState);
this.props.onExpand(event, !expandedState);
} else {
this.setState((prevState) => ({ expandedState: !prevState.expandedState }));
const { groupId } = this.props;
onToggle(e, groupId, !expandedState);
onToggle(event, groupId, !expandedState);
}
};

Expand Down Expand Up @@ -129,7 +129,7 @@ export class NavExpandable extends React.Component<NavExpandableProps, NavExpand
<button
className={styles.navLink}
id={srText ? null : this.id}
onClick={(e) => this.onExpand(e, context.onToggle)}
onClick={(event) => this.onExpand(event, context.onToggle)}
aria-expanded={expandedState}
tabIndex={isNavOpen ? null : -1}
{...buttonProps}
Expand Down