From 6a2b2654363c39ebf7b5cb4b728c9f80fa7b06ac Mon Sep 17 00:00:00 2001 From: Titani Date: Thu, 13 Apr 2023 14:01:22 -0400 Subject: [PATCH 1/4] fix(createIcon): Spread classNname to svg to fix broken images --- packages/react-icons/src/createIcon.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/react-icons/src/createIcon.tsx b/packages/react-icons/src/createIcon.tsx index 86f12683e6e..41adb5e12a9 100644 --- a/packages/react-icons/src/createIcon.tsx +++ b/packages/react-icons/src/createIcon.tsx @@ -11,6 +11,7 @@ export interface IconDefinition { export interface SVGIconProps extends Omit, 'ref'> { title?: string; + className?: string; } let currentId = 0; @@ -32,14 +33,14 @@ export function createIcon({ id = `icon-title-${currentId++}`; render() { - const { title, ...props } = this.props; + const { title, className, ...props } = this.props; const hasTitle = Boolean(title); const viewBox = [xOffset, yOffset, width, height].join(' '); return ( Date: Thu, 13 Apr 2023 14:21:02 -0400 Subject: [PATCH 2/4] only spread clasname when defined --- .../__snapshots__/EmptyStateIcon.test.tsx.snap | 2 +- .../__snapshots__/EmptyState.test.tsx.snap | 1 + .../__snapshots__/HelperText.test.tsx.snap | 2 +- .../__tests__/__snapshots__/Icon.test.tsx.snap | 6 +++--- .../__snapshots__/SearchInput.test.tsx.snap | 2 +- .../__snapshots__/TreeView.test.tsx.snap | 16 ++++++++-------- .../__tests__/__snapshots__/Select.test.tsx.snap | 14 +++++++------- packages/react-icons/src/createIcon.tsx | 3 ++- 8 files changed, 24 insertions(+), 22 deletions(-) diff --git a/packages/react-core/src/components/EmptyState/__tests__/Generated/__snapshots__/EmptyStateIcon.test.tsx.snap b/packages/react-core/src/components/EmptyState/__tests__/Generated/__snapshots__/EmptyStateIcon.test.tsx.snap index 70af63945e2..1812584f295 100644 --- a/packages/react-core/src/components/EmptyState/__tests__/Generated/__snapshots__/EmptyStateIcon.test.tsx.snap +++ b/packages/react-core/src/components/EmptyState/__tests__/Generated/__snapshots__/EmptyStateIcon.test.tsx.snap @@ -9,7 +9,7 @@ exports[`EmptyStateIcon should match snapshot (auto-generated) 1`] = `