diff --git a/packages/react-core/src/components/Radio/Radio.tsx b/packages/react-core/src/components/Radio/Radio.tsx index 73840d83570..7d6cf739a78 100644 --- a/packages/react-core/src/components/Radio/Radio.tsx +++ b/packages/react-core/src/components/Radio/Radio.tsx @@ -28,7 +28,7 @@ export interface RadioProps /** Name for group of radios */ name: string; /** A callback for when the radio selection changes. */ - onChange?: (checked: boolean, event: React.FormEvent) => void; + onChange?: (event: React.FormEvent, checked: boolean) => void; /** Aria label for the radio. */ 'aria-label'?: string; /** Description text of the radio. */ @@ -62,7 +62,7 @@ export class Radio extends React.Component } handleChange = (event: React.FormEvent) => { - this.props.onChange(event.currentTarget.checked, event); + this.props.onChange(event, event.currentTarget.checked); }; render() { diff --git a/packages/react-core/src/components/Radio/__tests__/Radio.test.tsx b/packages/react-core/src/components/Radio/__tests__/Radio.test.tsx index 767506d99f2..28ad8da24ff 100644 --- a/packages/react-core/src/components/Radio/__tests__/Radio.test.tsx +++ b/packages/react-core/src/components/Radio/__tests__/Radio.test.tsx @@ -79,7 +79,7 @@ describe('Radio', () => { render(); await user.click(screen.getByRole('radio')); - expect(props.onChange).toHaveBeenCalledWith(true, expect.any(Object)); + expect(props.onChange).toHaveBeenCalledWith(expect.any(Object), true); }); test('Radio description', () => { diff --git a/packages/react-core/src/deprecated/components/Wizard/examples/Wizard.md b/packages/react-core/src/deprecated/components/Wizard/examples/Wizard.md index 972acd4d677..682a423109f 100644 --- a/packages/react-core/src/deprecated/components/Wizard/examples/Wizard.md +++ b/packages/react-core/src/deprecated/components/Wizard/examples/Wizard.md @@ -227,7 +227,7 @@ class ProgressiveWizard extends React.Component { this.setState({ getStartedStepRadio: event.currentTarget.value })} + onChange={(event) => this.setState({ getStartedStepRadio: event.currentTarget.value })} label="Create a new thing" name="radio-step-start" id="radio-step-start-1" @@ -235,7 +235,7 @@ class ProgressiveWizard extends React.Component { this.setState({ getStartedStepRadio: event.currentTarget.value })} + onChange={(event) => this.setState({ getStartedStepRadio: event.currentTarget.value })} label="Update an existing thing" name="radio-step-start" id="radio-step-start-2" @@ -250,7 +250,7 @@ class ProgressiveWizard extends React.Component { this.setState({ createStepRadio: event.currentTarget.value })} + onChange={(event) => this.setState({ createStepRadio: event.currentTarget.value })} label="Quick create" name="radio-step-create" id="radio-step-create-1" @@ -258,7 +258,7 @@ class ProgressiveWizard extends React.Component { this.setState({ createStepRadio: event.currentTarget.value })} + onChange={(event) => this.setState({ createStepRadio: event.currentTarget.value })} label="Custom create" name="radio-step-create" id="radio-step-create-2" @@ -273,7 +273,7 @@ class ProgressiveWizard extends React.Component { this.setState({ updateStepRadio: event.currentTarget.value })} + onChange={(event) => this.setState({ updateStepRadio: event.currentTarget.value })} label="Quick update" name="radio-step-update" id="radio-step-update-1" @@ -281,7 +281,7 @@ class ProgressiveWizard extends React.Component { this.setState({ updateStepRadio: event.currentTarget.value })} + onChange={(event) => this.setState({ updateStepRadio: event.currentTarget.value })} label="Custom update" name="radio-step-update" id="radio-step-update-2" diff --git a/packages/react-integration/demo-app-ts/src/App.tsx b/packages/react-integration/demo-app-ts/src/App.tsx index 9a4ca29a589..ec8be27cb61 100755 --- a/packages/react-integration/demo-app-ts/src/App.tsx +++ b/packages/react-integration/demo-app-ts/src/App.tsx @@ -98,7 +98,7 @@ class App extends React.Component<{}, AppState> { label={`Light theme`} name="light-theme" isChecked={!isDarkTheme} - onChange={checked => checked && this.onThemeSelect(false)} + onChange={(_event: React.FormEvent, checked: boolean) => checked && this.onThemeSelect(false)} /> @@ -108,7 +108,7 @@ class App extends React.Component<{}, AppState> { aria-label="Dark theme" name="dark-theme" isChecked={isDarkTheme} - onChange={checked => checked && this.onThemeSelect(true)} + onChange={(_event: React.FormEvent, checked: boolean) => checked && this.onThemeSelect(true)} /> diff --git a/packages/react-integration/demo-app-ts/src/components/demos/RadioDemo/RadioDemo.tsx b/packages/react-integration/demo-app-ts/src/components/demos/RadioDemo/RadioDemo.tsx index 58cff60e729..dfff5946968 100644 --- a/packages/react-integration/demo-app-ts/src/components/demos/RadioDemo/RadioDemo.tsx +++ b/packages/react-integration/demo-app-ts/src/components/demos/RadioDemo/RadioDemo.tsx @@ -5,7 +5,7 @@ export class RadioDemo extends Component { value: '4' }; - handleChange = (_checked: boolean, event: React.FormEvent) => { + handleChange = (event: React.FormEvent) => { const { value } = event.currentTarget; this.setState({ value }); };