From 42257e666950c4d3a031a983e87a7e8cd739a994 Mon Sep 17 00:00:00 2001 From: nicolethoen Date: Wed, 3 May 2023 22:05:01 -0400 Subject: [PATCH 1/5] fix(Wizard): update close button and title structures --- .../src/components/Wizard/WizardHeader.tsx | 15 +- .../components/Wizard/WizardHeader.tsx | 14 +- .../__snapshots__/WizardBody.test.tsx.snap | 4 +- .../__snapshots__/WizardFooter.test.tsx.snap | 2 +- .../WizardFooterInternal.test.tsx.snap | 10 +- .../__snapshots__/WizardHeader.test.tsx.snap | 21 +- .../__snapshots__/WizardNav.test.tsx.snap | 4 +- .../__snapshots__/WizardNavItem.test.tsx.snap | 4 +- .../__snapshots__/WizardToggle.test.tsx.snap | 20 +- .../__snapshots__/Wizard.test.tsx.snap | 298 +++++++++--------- .../cypress/integration/wizard.spec.ts | 2 +- .../integration/wizarddeprecated.spec.ts | 4 +- 12 files changed, 203 insertions(+), 195 deletions(-) diff --git a/packages/react-core/src/components/Wizard/WizardHeader.tsx b/packages/react-core/src/components/Wizard/WizardHeader.tsx index b197e6faa86..3d1daf80bcd 100644 --- a/packages/react-core/src/components/Wizard/WizardHeader.tsx +++ b/packages/react-core/src/components/Wizard/WizardHeader.tsx @@ -36,14 +36,15 @@ export const WizardHeader: React.FunctionComponent = ({ }: WizardHeaderProps) => (
{!isCloseHidden && ( - +
+ +
)} - - - {title || <> </>} - +
+

{title || <> }

+
{description && ( diff --git a/packages/react-core/src/deprecated/components/Wizard/WizardHeader.tsx b/packages/react-core/src/deprecated/components/Wizard/WizardHeader.tsx index a41307fcb4f..72264f394b0 100644 --- a/packages/react-core/src/deprecated/components/Wizard/WizardHeader.tsx +++ b/packages/react-core/src/deprecated/components/Wizard/WizardHeader.tsx @@ -36,13 +36,15 @@ export const WizardHeader: React.FunctionComponent = ({ }: WizardHeaderProps) => (
{!hideClose && ( - +
+ +
)} - - {title || <> </>} - +
+

{title || <> }

+
{description && ( {description} diff --git a/packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardBody.test.tsx.snap b/packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardBody.test.tsx.snap index 0aac52d258c..5f65ee15ccf 100644 --- a/packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardBody.test.tsx.snap +++ b/packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardBody.test.tsx.snap @@ -3,10 +3,10 @@ exports[`WizardBody should match snapshot (auto-generated) 1`] = `
any
diff --git a/packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardFooter.test.tsx.snap b/packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardFooter.test.tsx.snap index 0f1112c6911..758f6a43176 100644 --- a/packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardFooter.test.tsx.snap +++ b/packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardFooter.test.tsx.snap @@ -3,7 +3,7 @@ exports[`WizardFooter should match snapshot (auto-generated) 1`] = `
any
diff --git a/packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardFooterInternal.test.tsx.snap b/packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardFooterInternal.test.tsx.snap index 6e7d65c6f2f..16c22891d0e 100644 --- a/packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardFooterInternal.test.tsx.snap +++ b/packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardFooterInternal.test.tsx.snap @@ -3,11 +3,11 @@ exports[`WizardFooterInternal should match snapshot (auto-generated) 1`] = `