Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Upload: Error message should not be inside drag/drop container area #2797

Closed
mturley opened this issue Mar 9, 2020 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@mturley
Copy link

@mturley mturley commented Mar 9, 2020

From @mcoker's comment here: patternfly/patternfly-react#3865 (comment)

In the File Upload HTML example with an error message, the .pf-c-file-upload__message.pf-m-error element is inside the main .pf-c-file-upload container element. When the .pf-m-drag-hover class is also applied to that container while a message is present, the message appears inside the blue background of the drag/drop area:

Screenshot 2020-03-09 14 32 38

In the corresponding React example I used a FormGroup to add the error message instead of having the message be part of the file upload component:

Screenshot 2020-03-09 11 32 30

We should either change the HTML/CSS in core to place this message outside the container, or remove the .pf-c-file-upload__message CSS entirely and use a FormGroup in that example instead.

cc @mcarrano @christiemolloy

@redallen

This comment has been minimized.

Copy link
Contributor

@redallen redallen commented Mar 16, 2020

🎉 This issue has been resolved in version 2.68.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@redallen redallen added the released label Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.