Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of Stacked Bar Chart #556

Closed
mresti opened this issue Dec 20, 2016 · 5 comments

Comments

@mresti
Copy link
Contributor

commented Dec 20, 2016

Hi,

I've just started working on a project using Patternfly. One of the requirements of this project is to use Stacked Bar Chart:

seleccion_092

This chart is a bar chart that I had developed using patternfly, but I didn't find in the documentation an example for stacked bar chart (https://www.patternfly.org/pattern-library/data-visualization/bar-chart/#_).

Can I send a PR with an example to use Stacked Bar Chart in projects?

@sergio-ocon can you help me?

@chargio

This comment has been minimized.

Copy link

commented Dec 21, 2016

What are you missing?

I see an example code here:
https://www.patternfly.org/pattern-library/data-visualization/bar-chart/#_code

@LHinson

This comment has been minimized.

Copy link
Member

commented Dec 21, 2016

@sergio-ocon, @mresti is right. We don't have the version with the stacked bars (a bar with multiple colors)

@mresti Yes! We love to get this added to PatternFly. Thanks for reaching out to us and offering to contribute! Are you interested in contributing the implementation? Would you be willing to help out with design documentation too and sending a PR to our design repo [1]? Happy to help you out in any way that you might need.

[1] https://github.com/patternfly/patternfly-design/tree/master/pattern-library/data-visualization/bar-chart/design

@mresti

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2016

@sergio-ocon @LHinson Thanks!!!

@LHinson Yes, I am interested in contributing in this project with the implementation and design documentation. I will send a PR to design repo[1] and a PR to implement repo [2].

[1] https://github.com/patternfly/patternfly-design/tree/master/pattern-library/data-visualization/bar-chart/design
[2] https://github.com/patternfly/patternfly

@LHinson

This comment has been minimized.

Copy link
Member

commented Dec 21, 2016

@mresti That's awesome @mresti Reach out to me anytime if you need anything.

FYI - I just sent an invite to your gmail to our PatternFly slack channel. There is a lot of conversation happening there and would be a good place to reach out to us.

@LHinson

This comment has been minimized.

Copy link
Member

commented Feb 1, 2017

Thanks for your contribution @mresti! Going to close this out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.