Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management of Font Awesome assets #830

Closed
mcoker opened this issue Oct 23, 2018 · 1 comment
Closed

Management of Font Awesome assets #830

mcoker opened this issue Oct 23, 2018 · 1 comment
Assignees
Milestone

Comments

@mcoker
Copy link
Contributor

mcoker commented Oct 23, 2018

Currently the FA icons we're using are from the default set, stripped down to the icons specified to be used in PF4. I talked to @mindreeper2420 and he shared some assets used for the original implementation.

How do we want to manage these going forward? Do we want to use a tool like Iconmoon or Fontello to make management easier? Should we add global vars for the content strings to use when defining an icon directly into a pseudo element (ie, not using .fas.fa-icon-name) as mentioned in the breadcrumb component?

Also check to see what we should do about thes PF3 icons

And maybe open a separate issue for a demo page

cc @matthewcarleton @LHinson

@mcoker
Copy link
Contributor Author

mcoker commented Nov 12, 2018

related - #771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants