Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input-group): unnest text class #2318

Merged
merged 2 commits into from Oct 4, 2019
Merged

fix(input-group): unnest text class #2318

merged 2 commits into from Oct 4, 2019

Conversation

SpyTec
Copy link
Contributor

@SpyTec SpyTec commented Oct 1, 2019

fixes #2286

Not sure how to move label into .pf-c-input-group__text as the order needs to be label.pf-c-input-group__text

cc @mcoker

@patternfly-build
Copy link

PatternFly-Next preview: https://patternfly-next-pr-2318.surge.sh

mcoker
mcoker reviewed Oct 1, 2019
View reviewed changes
src/patternfly/components/InputGroup/docs/code.md
| `.pf-c-input-group` | `<div>` | Initiates the input group. **Required** |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

mcoker
mcoker reviewed Oct 1, 2019
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SpyTec! Recommended some SCSS to avoid creating a separate label.pf-c-input-group__text {} selector

@SpyTec
Copy link
Contributor Author

SpyTec commented Oct 4, 2019

Fixed, sorry for the late response

mcoker
mcoker approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @SpyTec!

@mcoker mcoker merged commit 9160a10 into patternfly:master Oct 4, 2019
@redallen
Copy link
Contributor

redallen commented Oct 4, 2019

🎉 This PR is included in version 2.33.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SpyTec SpyTec deleted the fix/input-group branch October 4, 2019 20:15
@redallen redallen mentioned this pull request Oct 7, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoker mcoker mcoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SpyTec @patternfly-build @redallen @mcoker