Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inline-edit): firefox bug causes alignment issue #2706

Merged
merged 3 commits into from Feb 12, 2020
Merged

fix(inline-edit): firefox bug causes alignment issue #2706

merged 3 commits into from Feb 12, 2020

Conversation

mattnolting
Copy link
Contributor

@patternfly-build
Copy link

patternfly-build commented Feb 12, 2020 •
edited

Preview: https://patternfly-next-pr-2706.surge.sh

CSS Size Report
NameCurrentPreviousDiff %
components/InlineEdit/inline-edit.css3.5 kB3.1 kB11.68
patternfly-ie11.css511.1 kB510.6 kB0.09
patternfly.min.css569.2 kB568.8 kB0.07
patternfly-no-reset.css646.6 kB646.2 kB0.06
patternfly.css648.4 kB648.0 kB0.06

A11y report: https://patternfly-next-pr-2706-coverage.surge.sh

christiemolloy
christiemolloy approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@christiemolloy christiemolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christiemolloy christiemolloy merged commit 6f56e16 into patternfly:master Feb 12, 2020
@redallen
Copy link
Contributor

🎉 This PR is included in version 2.61.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mattnolting mattnolting deleted the inline-edit-ff branch February 24, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiemolloy christiemolloy christiemolloy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mattnolting @patternfly-build @redallen @christiemolloy @seanforyou23