Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fileupload): change border for drag hover outside of psuedo selector #2776

Merged
merged 3 commits into from Mar 5, 2020

Conversation

@christiemolloy
Copy link
Member

christiemolloy commented Mar 4, 2020

fixes .pf-c-file-upload.p-m-drag-hover so that the border is set on that class rather than the ::after pseudo selector as that also has opacity of 0.1 set on it, which was affecting the opacity of the border.

@christiemolloy christiemolloy requested review from mattnolting, mcoker and mturley Mar 4, 2020
@patternfly-build

This comment has been minimized.

Copy link

patternfly-build commented Mar 4, 2020

Preview: https://patternfly-next-pr-2776.surge.sh

A11y report: https://patternfly-next-pr-2776-coverage.surge.sh

CSS Size Report
NameCurrentPreviousDiff %
components/FileUpload/file-upload.css5.2 kB5.0 kB4.50
patternfly.min.css587.2 kB587.0 kB0.04
patternfly-no-reset.css666.8 kB666.5 kB0.04
patternfly.css668.6 kB668.3 kB0.04
patternfly-ie11.css520.9 kB520.8 kB0.02
@mturley
mturley approved these changes Mar 4, 2020
Copy link

mturley left a comment

LGTM, thanks @christiemolloy !

@@ -34,6 +34,7 @@

&.pf-m-drag-hover {
position: relative;
border: var(--pf-c-file-upload--m-drag-hover--BorderWidth) solid var(--pf-c-file-upload--m-drag-hover--BorderColor);

This comment has been minimized.

Copy link
@mcoker

mcoker Mar 4, 2020

Contributor

adding a border is going to make the component shrink/grow when the class is toggled. You could use the ::before pseudo class to draw the border

@mturley

This comment has been minimized.

Copy link

mturley commented Mar 5, 2020

@christiemolloy while we're in here, in the "File upload error" example can we move the aria-invalid="true" from the <input> to the <textarea>?

Copy link
Contributor

mattnolting left a comment

Perfect 🎉

@mcoker
mcoker approved these changes Mar 5, 2020
Copy link
Contributor

mcoker left a comment

perfect!

@mattnolting mattnolting merged commit 6cc198d into patternfly:master Mar 5, 2020
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_a11y Your tests passed on CircleCI!
Details
@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Mar 5, 2020

🎉 This PR is included in version 2.67.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@redallen redallen added the released label Mar 5, 2020
mattnolting added a commit to mattnolting/patternfly that referenced this pull request Mar 6, 2020
…tor (patternfly#2776)

* fix(fileupload): change border for drag hover outside of psuedo selector
mcoker added a commit that referenced this pull request Mar 6, 2020
* fix(notificationdrawer): updated dropdowns so they dont overflow parent (#2767)

* fix(fileupload): change border for drag hover outside of psuedo selector (#2776)

* fix(fileupload): change border for drag hover outside of psuedo selector

* feat(divider): added vertical divider variation (#2734)

* feat(nothing): try a minor version bump (#2784)

* fix(release-notes): updated release notes for 2020.03 release (#2785)

* chore(flex): scoped flex layout workspace styles to layout examples (#2787)

* fix(nav): fixed divider positioning and color declarations (#2788)

* fix(release-notes): updated release notes for 2020.03 release (#2789)

* chore(a11y): fix a11y upload report (#2790)

Co-authored-by: Matt Nolting <matthew.nolting@gmail.com>
Co-authored-by: zallen <47335686+redallen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.