Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(a11y): fix a11y upload report #2790

Merged
merged 1 commit into from Mar 6, 2020
Merged

chore(a11y): fix a11y upload report #2790

merged 1 commit into from Mar 6, 2020

Conversation

redallen
Copy link
Contributor

@redallen redallen commented Mar 6, 2020

Whoops! Silly mistake

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@patternfly-build
Copy link

patternfly-build commented Mar 6, 2020

Preview: https://patternfly-next-pr-2790.surge.sh

CSS Size Report
NameCurrentPreviousDiff %
There are no changes in CSS file sizes

A11y report: https://patternfly-next-pr-2790-coverage.surge.sh

@redallen redallen merged commit 5a37eb4 into patternfly:master Mar 6, 2020
mcoker added a commit that referenced this pull request Mar 6, 2020
* fix(notificationdrawer): updated dropdowns so they dont overflow parent (#2767)

* fix(fileupload): change border for drag hover outside of psuedo selector (#2776)

* fix(fileupload): change border for drag hover outside of psuedo selector

* feat(divider): added vertical divider variation (#2734)

* feat(nothing): try a minor version bump (#2784)

* fix(release-notes): updated release notes for 2020.03 release (#2785)

* chore(flex): scoped flex layout workspace styles to layout examples (#2787)

* fix(nav): fixed divider positioning and color declarations (#2788)

* fix(release-notes): updated release notes for 2020.03 release (#2789)

* chore(a11y): fix a11y upload report (#2790)

Co-authored-by: Matt Nolting <matthew.nolting@gmail.com>
Co-authored-by: zallen <47335686+redallen@users.noreply.github.com>
@redallen
Copy link
Contributor Author

🎉 This PR is included in version 2.68.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

redallen added a commit that referenced this pull request May 12, 2020
* setup v4 prerelease

* fix(about-modal): add a comment to test v4 release (#2764)

* chore(build): only release from v4 branch

* build(semantic-release): add git tag so we start on 4.0.0

* fix(readme): test semantic-release

* fix upload preview url and semantic release config

* tweak semantic release deploy

* semantic release branches

* fix(nothing): semantic release debugging

* debugging

* more debugging

* fix(semantic-release): i think i finally got it

* add back tests

* fix(test): remove unused file (#2771)

* Merge remote-tracking branch 'upstream/master' into v4 (#2791)

* fix(notificationdrawer): updated dropdowns so they dont overflow parent (#2767)

* fix(fileupload): change border for drag hover outside of psuedo selector (#2776)

* fix(fileupload): change border for drag hover outside of psuedo selector

* feat(divider): added vertical divider variation (#2734)

* feat(nothing): try a minor version bump (#2784)

* fix(release-notes): updated release notes for 2020.03 release (#2785)

* chore(flex): scoped flex layout workspace styles to layout examples (#2787)

* fix(nav): fixed divider positioning and color declarations (#2788)

* fix(release-notes): updated release notes for 2020.03 release (#2789)

* chore(a11y): fix a11y upload report (#2790)

Co-authored-by: Matt Nolting <matthew.nolting@gmail.com>
Co-authored-by: zallen <47335686+redallen@users.noreply.github.com>

* feat(divider): added vertical divider variation (#2734)

* chore(flex): scoped flex layout workspace styles to layout examples (#2787)

* Chore(build) - remove IE11 support from build (#2806)

* feat(divider): added vertical divider variation (#2734)

* chore(build): removed ie11 support from build (#2751)

* chore(build): removed IE11 text from README (#2751)

* chore(build): reverted flex css updates pulled in during rebase (#2751)

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>

* fix(color): updated success-100, success-200, green-500 global vars (#2817)

* fix(chipgroup): modified max width for chip label (#2823)

* fix(wizard): made active step bold, fixed in-page workspace example (#2805)

* fix(radio, check): fixed radio left margin overflow, error in selector (#2799)

* fix(radio, check): fixed radio left margin overflow, error in selector

* fix(color): updated black global and background global/component vars (#2818)

* fix(color): updated black global and background global/component vars

* chore(workspace): updated workspace backgroundcolor--300 to --200

* fix(table): updated table font var (#2831)

* fix(file-upload): removed message container, added form to error example (#2807) (#2833)

* fix(file-upload): removed message container, added form to error example

* chore(fileupload): updated examples to be a div instead of form

* fix(colors): updated cyan-600 cyan-700 blue-600 and blue-700 (#2832)

* chore(v4): prevent merging in github from triggering a release (#2835)

* feat(dropdown): added dropdown toggle image and text item modifier (#2803)

* fix(tooltip): reduced space around component (#2763)

* fix(popover): reduced space between/around elements (#2762)

* fix(popover): reduced space between/around elements

* fix(popover): decrease component font-size and title size variation

* fix(popover): decrease space above footer

* fix(datalist): updated compact font-size (#2777)

* fix(table): updated compact spacing (#2775)

* fix(select/contextselector): updated name for menu search element (#2826)

* fix(page): removed margin-top/bottom from header tools (#2821)

* fix(accordion): updated spacing, removed box shadow and shadow variation (#2760)

* fix(modal): reduced spacing (#2761)

* fix(modal): reduced spacing

* Merge remote-tracking branch 'upstream/master' into v4 (#2844)

* fix(file-upload): removed message container, added form to error example (#2807)

* fix(file-upload): removed message container, added form to error example

* chore(fileupload): updated examples to be a div instead of form

* feat(docs): publish docs to NPM (#2839)

* fix(md): add example css to dist (#2840)

* chore(lint): dont lint example CSS (#2841)

Co-authored-by: zallen <47335686+redallen@users.noreply.github.com>

* refactor(tabs): updated to new tab design (#2757)

* fix(page): reduced space between tertiary nav, breadcrumbs, main section (#2837)

* fix(card): renamed vars, updated docs (#2759)

* chore(button-icon): added pre-config option (#2863)

* fix(form-control): enabled success/invalid states for readonly controls (#2753)

* fix(table): replaced expanded content box shadow with border (#2861)

* fix(tooltip): added box shadow (#2855)

* fix(sass-utilities): made bs-variables optional include (#2871)

* fix(box-shadow): update global shadows, add xl, update shadow utility (#2854)

* fix(box-shadow): update global shadows, add xl, update shadow utility

* fix(shadows): update small directional blur, alpha

* feat(base): made shield styles optional by default (#2769) (#2872)

* fix(wizard): updates to shadows and borders (#2860)

* fix(modal): updated box shadow size (#2859)

* fix(clipboard-copy): replaced expandable box-shadow with border (#2856)

* fix(modal): left aligned footer actions, removed pf-m-align-left (#2881)

* fix(components): changed component media queries to be mobile first (#2816)

* fix(page): updated page and page header background colors (#2883)

* fix(table-td-wrapping): added to overflow-wrap (#2868)

* fix(table-td-word-break): updated word-break

* feat(card): added flat variation (#2886)

* fix(v4): merge master for 2020.04 release (#2888)

* fix(empty-state): center content, fix vars, adjust secondary margin (#2866)

* fix(empty-state): center content, fix vars, adjust secondary margin

* fix(emptystate): applied margin to children of secondary element

* fix(empty-state): centered empty state contents vertically

* fix(empty-state): added full-height modifier

* fix(drawer): removed m-border, enabled m-no-border on inline/static (#2887)

* fix(button): added modifiers to position icon in button (#2828)

* fix(data-list): changed expanded content shadow to a border (#2885)

* fix(repo): merge master for 2020.04 release (#2901)

* fix(file-upload): removed message container, added form to error example (#2807)

* fix(file-upload): removed message container, added form to error example

* chore(fileupload): updated examples to be a div instead of form

* feat(docs): publish docs to NPM (#2839)

* fix(md): add example css to dist (#2840)

* chore(lint): dont lint example CSS (#2841)

* feat(base): made shield styles optional by default (#2769)

* Revert "feat(base): made shield styles optional by default (#2769)" (#2867)

This reverts commit 0b32834.

* fix(table): updated text in column management demo modal (#2875)

* feat(infrastructure): parse hbs files (#2865)

* feat(infrastructure): parse hbs files

* fix(select): fixed attribute issue with select-menu-fieldset

* fix(select): update aria-label usage on select-menu-fieldset

* for non-group menus, use aria-label="Select input"
* for grouped menus, use aria-labelled by on fieldset, labeled by the group title
* updates match the react select component examples

Co-authored-by: Michael Coker <mcoker@redhat.com>

* chore(repo): replaced 288 occurences of patternfly-next with patternfly (#2880)

* fix(repo): update release notes (#2900)

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
Co-authored-by: Joachim <jschuler@redhat.com>
Co-authored-by: Michael Coker <mcoker@redhat.com>

* chore(page): made roles on header and main elements optional (#2899)

* fix(radio): fixed issue where radio is cut off when comes after label (#2912)

* fix(app launcher): applied external link icon class to icon wrapper (#2904)

* fix(dev-lite): created titles from path on disk rather than frontmatter (#2895)

* feat(colors): added new cyan, gold, green, red colors, updated blue (#2906)

* fix(datalist): remove margin bottom for action (#2923)

* fix(login): keeps login from shrinking based on content size (#2917)

* fix(wizard): move modifier to body (#2924)

* fix(tabs): Updates class name for tabs button to be tabs link (#2919)

* Fix inline drawer panel left border (#2897)

* fix(drawer-panel): add panel border, rm aria-expanded

* style(vertical-nav): refactored css structure (#2884)

* style(vertical-nav): refactored css structure

* fix(clipboardcopy): updated buttons to use button component (#2922)

* fix(breadcrumb): add word-break, display link and icon inline, move divider (#2916)

* fix(breadcrumb): add word-break, display link and icon inline

* fix(breadcrumb): include divider before link instead of after

* fix(breadcrumb): dont let item text wrap under separator

* chore(breadcrumb): rewrote breadcrumb divider hbs

* fix(input group): replaced Dropdown with Select (#2934)

* chore(v4): merged master into v4 (#2933)

* fix(file-upload): removed message container, added form to error example (#2807)

* fix(file-upload): removed message container, added form to error example

* chore(fileupload): updated examples to be a div instead of form

* feat(docs): publish docs to NPM (#2839)

* fix(md): add example css to dist (#2840)

* chore(lint): dont lint example CSS (#2841)

* feat(base): made shield styles optional by default (#2769)

* Revert "feat(base): made shield styles optional by default (#2769)" (#2867)

This reverts commit 0b32834.

* fix(table): updated text in column management demo modal (#2875)

* feat(infrastructure): parse hbs files (#2865)

* feat(infrastructure): parse hbs files

* fix(select): fixed attribute issue with select-menu-fieldset

* fix(select): update aria-label usage on select-menu-fieldset

* for non-group menus, use aria-label="Select input"
* for grouped menus, use aria-labelled by on fieldset, labeled by the group title
* updates match the react select component examples

Co-authored-by: Michael Coker <mcoker@redhat.com>

* chore(repo): replaced 288 occurences of patternfly-next with patternfly (#2880)

* fix(repo): update release notes (#2900)

* chore(snippets): gulpify snippets, add html validation (#2894)

* chore(snippets): gulpify snippets, reduce build time to 5s

* fix scripts

* fix(demos): publish demos to NPM (#2908)

* fix(release-notes): fix formatting of release notes (#2909)

* fix(release-notes): fix formatting of release notes

* fix closing parentheses

* chore(copyclipboard): resolve merge conflict

* fix(package.json): updates

Co-authored-by: zallen <47335686+redallen@users.noreply.github.com>
Co-authored-by: Joachim <jschuler@redhat.com>

* fix(optionsmenu): added color declaration to menu items (#2938)

* feat(example): add select-disabled-typeahead-example.hbs (#2882)

* docs(select): added disabled typeahead select example

* fix(form): moved helper text icon from login to form component (#2928)

* fix(global vars): updated pf-color-green-50 (#2940)

* fix(chip): refactor styles (#2941)

* fix(chip): refactor styles

* fix(chips): add changes to chip group

* fix(inputgroup): remove legacy button styles (#2935)

* fix(expandable): renamed expandable to expandable section (#2937)

* fix(expandablesection): renamed expandable to expandable section

* fix(wizard): made desktop nav 250px, remove compact modifier (#2936)

* fix(alerts): updated styling for better accessibility (#2921)

* fix(global): hid vertical nav at 1200px, updated component spacing (#2962)

* fix(global): hid vertical nav at 1200px, updated component spacing

* Moving some top level scss files into directory structure" (#2960)

* chore(scss):

moved files to base dir(part one)

* chore(scss): scss cleanup

added 'addons' directory
fixed gulp files to handle new directory layout
fixed gatsby files to handle new directory layout
removed patternfly-imports.scss file

* chore(scss): remove addons directory

* chore(scss): remove addons directory from gulp.js file

* chore(scss): added .scss suffix where needed

Also added a check to build step

* refactor(separators-dividers): removed component separators, added dividers (#2944)

* fix(components): removed transparent borders (#2963)

* fix(modal): added header, moved padding from container to elements (#2969)

* fix(modal-box): added header, moved padding from container to elements

* fix(nav-scroll): updated nav buttons to inline (#2942)

* fix(content): margin should not be on first-child or last-child (#2930)

* fix(content): removed margin-top from first-child, removed margin-bottom from last-child

* feat(label): refactored label component (#2943)

* feat(label): refactored label component

* fix(components): removed presentational hover/active/focus/disabedl classes (#2975)

* fix(components): added BEM elements that wrap icons (#2927)

* fix(form): refactored label/control sections, added label help (#2766)

* fix(form): create label/action section of form group, refactor css

* fix(chipgroup): updated chip group behavior, structure (#2961)

* fix(wizard): reworked wizard so it can be used in modal (#2964)

* refactor(nav-and-sidebar-theme): updated nav to dark theme (#2978)

* chore(v4): merge master (#3000)

* fix(file-upload): removed message container, added form to error example (#2807)

* fix(file-upload): removed message container, added form to error example

* chore(fileupload): updated examples to be a div instead of form

* feat(docs): publish docs to NPM (#2839)

* fix(md): add example css to dist (#2840)

* chore(lint): dont lint example CSS (#2841)

* feat(base): made shield styles optional by default (#2769)

* Revert "feat(base): made shield styles optional by default (#2769)" (#2867)

This reverts commit 0b32834.

* fix(table): updated text in column management demo modal (#2875)

* feat(infrastructure): parse hbs files (#2865)

* feat(infrastructure): parse hbs files

* fix(select): fixed attribute issue with select-menu-fieldset

* fix(select): update aria-label usage on select-menu-fieldset

* for non-group menus, use aria-label="Select input"
* for grouped menus, use aria-labelled by on fieldset, labeled by the group title
* updates match the react select component examples

Co-authored-by: Michael Coker <mcoker@redhat.com>

* chore(repo): replaced 288 occurences of patternfly-next with patternfly (#2880)

* fix(repo): update release notes (#2900)

* chore(snippets): gulpify snippets, add html validation (#2894)

* chore(snippets): gulpify snippets, reduce build time to 5s

* fix scripts

* fix(demos): publish demos to NPM (#2908)

* fix(release-notes): fix formatting of release notes (#2909)

* fix(release-notes): fix formatting of release notes

* fix closing parentheses

* docs(conduct): add missing code of conduct (#2945)

* fix(bug): updated steps to be used for dev env (#2952)

* Readme fix 2947 (#2957)

* fix(bug): updated steps to be used for dev env

* fix(bug): have both dev setups documented

* fix(bug): have both dev setups documented

* fix(bug): readme changes

 added back in the cli step also removed the dev:lite config for now
 This is something that we can share when talking with end user's

* fix(bug): readme changes

 added back in the cli step also removed the dev:lite config for now
 This is something that we can share when talking with end user's

* fix(release-notes): updated release notes for 2020.05 release (#2970)

* chore(dev-lite): remove examples and components on delete (#2984)

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
Co-authored-by: Joachim <jschuler@redhat.com>
Co-authored-by: Michael Coker <mcoker@redhat.com>
Co-authored-by: Dana Gutride <dgutride@gmail.com>
Co-authored-by: Doug Donahue <57504257+ddonahue007@users.noreply.github.com>

* fix(v4): force bump (#3001)

* fix(table-row-height): fixed borders, row height, focus (#2965)

* feat(global): made redhat font default, add opt-in for overpass (#2955)

* feat(global): made redhat font default, add opt-in for overpass

* fix(card): increase header specificity

* fix(nav): made nav__list a flex parent (#3006)

* fix(docs): bump gatsby-theme to fix nav (#3017)

* fix(global): replaced use of RHD with RHT, remove RHD (#3023)

* fix(global): replaced use of RHD with RHT, remove RHD

* chore(table): changed column management modal demo button to link (#3036)

* fix(docs): bump theme to fix top nav (#3029)

* fix(docs): bump theme to fix top nav

* upgrade gatsby

* bump react as well

* fix(components): added pf-m-active to toggles (#3038)

* fix(card): moved __header to __title, __head to __header (#3035)

* fix(card): moved __header to __title, __head to __header

* fix(toolbar): removes pf-c-toolbar component (#3039)

* fix(toolbar): removed pf-c-toolbar component

* fix(toolbar): removed toolbar layout (#3045)

* fix(data-toolbar): renamed data-toolbar to toolbar (#3046)

* fix(aboutmodalbox): increased specificity of close button selector (#3008)

* fix(backdrop): removed blur, renamed var (#3009)

* fix(applauncher): cleanupvariables (#3012)

* fix(optionsmenu): cleaned up vars (#3018)

* fix(vars): removed golden ratio var (#3014)

* fix(wizard): removed unnecessary property declaration and var (#3013)

* feat(spacer): added 80px spacer (#3027)

* feat(spacer): added 80px spacer

* fix(tabs-box-border-top): fixed box vertical border top (#3051)

* fix(pagination): removed options menu per page text styling (#3047)

* fix(chip-group): refactored structure so chip-group no longer nests (#3058)

* fix(chip-group): refactored structure so chip-group no longer nests

* fix(dropdown): cleaned up vars (#3020)

* fix(pagination): updated bottom pagination design (#3050)

* fix(pagination): updated bottom pagination design

* fix(datalist): cleaned up vars (#3025)

* fix(switch): cleaned up vars (#3026)

* fix(components): split out transform variables (#3037)

* refactor(nav-structure): removed __simple-list, added support for -m-horizontal/-m-tertiary at root (#3062)

* refactor(nav-structure): removed __list-tertiary

* fix(table-modifier-bugs): fixed truncate and wrap mod bugs (#3031)

* fix(table-modifier-bugs): fixed truncate and wrap mod bugs

* fix(select): adjusted chip group margin in toggle (#3070)

* fix(button): updated control variation disabled state (#3049)

* fix(button): updated control variation disabled state

* fix(page): removed unnecessary vars (#3066)

* fix(button): clean up vars (#3028)

* fix(button): clean up vars

Co-authored-by: Michael Coker <mcoker@redhat.com>

* build(deps): bump minimist from 1.2.0 to 1.2.3 in /build/patternfly-cli (#2925)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.3.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(modal-box): added __header element (#3084)

* fix(modal-box): added __header element

* fix(chip): adjusted chip top/bottom padding, chip group margin in select (#3079)

* fix(datalist): fixed shadows on selected rows (#3068)

* fix(accordion): cleaned up vars (#3016)

* fix(select): cleaned up vars (#3019)

* fix(nav-vars): added missing padding--xl vars (#3090)

* fix(page): removed pf-m-mobile/icon/user, added hidden/visible (#3091)

* fix(table-vars): updated min-width vars, removed unused (#3074)

* fix(table-vars): updated min-width vars, removed unused

* fix(emptystate): split single padding var to top/right/bottom/left (#3092)

* chore(master): change release stream to v4

Co-authored-by: Matt Nolting <matthew.nolting@gmail.com>
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
Co-authored-by: Christie Molloy <cmolloy@redhat.com>
Co-authored-by: Evan <evan.wilkinson@gmail.com>
Co-authored-by: Joachim <jschuler@redhat.com>
Co-authored-by: Michael Coker <mcoker@redhat.com>
Co-authored-by: VA Kenyon <35377991+ValerieKenyon@users.noreply.github.com>
Co-authored-by: Doug Donahue <57504257+ddonahue007@users.noreply.github.com>
Co-authored-by: Dana Gutride <dgutride@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants