From c8dca07b2e81db6ee2976ecde4300d207838b801 Mon Sep 17 00:00:00 2001 From: nicolethoen Date: Wed, 25 Mar 2026 08:16:13 -0400 Subject: [PATCH 1/3] chore: add pr previews --- .github/workflows/build-lint-test.yml | 12 ++++-- .github/workflows/build.yml | 56 --------------------------- .github/workflows/check-pr.yml | 3 ++ .github/workflows/pr-preview.yml | 47 ++++++++++++++++++++++ 4 files changed, 58 insertions(+), 60 deletions(-) delete mode 100644 .github/workflows/build.yml create mode 100644 .github/workflows/pr-preview.yml diff --git a/.github/workflows/build-lint-test.yml b/.github/workflows/build-lint-test.yml index c35cc7e..047c635 100644 --- a/.github/workflows/build-lint-test.yml +++ b/.github/workflows/build-lint-test.yml @@ -1,11 +1,15 @@ name: build-lint-test on: workflow_call: + inputs: + pr-number: + required: false + type: string jobs: build: runs-on: ubuntu-latest env: - GH_PR_NUM: ${{ github.event.number }} + GH_PR_NUM: ${{ inputs.pr-number }} steps: - uses: actions/checkout@v4 - run: | @@ -41,7 +45,7 @@ jobs: lint: runs-on: ubuntu-latest env: - GH_PR_NUM: ${{ github.event.number }} + GH_PR_NUM: ${{ inputs.pr-number }} needs: build steps: - uses: actions/checkout@v4 @@ -78,7 +82,7 @@ jobs: test_jest: runs-on: ubuntu-latest env: - GH_PR_NUM: ${{ github.event.number }} + GH_PR_NUM: ${{ inputs.pr-number }} needs: build steps: - uses: actions/checkout@v4 @@ -120,7 +124,7 @@ jobs: test_a11y: runs-on: ubuntu-latest env: - GH_PR_NUM: ${{ github.event.number }} + GH_PR_NUM: ${{ inputs.pr-number }} needs: build steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml deleted file mode 100644 index fd606e3..0000000 --- a/.github/workflows/build.yml +++ /dev/null @@ -1,56 +0,0 @@ -name: build -on: - workflow_call: -jobs: - build: - runs-on: ubuntu-latest - env: - GH_PR_NUM: ${{ github.event.number }} - steps: - - uses: actions/checkout@v4 - - run: | - if [[ ! -z "${GH_PR_NUM}" ]]; then - echo "Checking out PR" - git fetch origin pull/$GH_PR_NUM/head:tmp - git checkout tmp - fi - - uses: actions/cache@v4 - id: setup-cache - name: Cache setup - with: - path: | - README.md - package.json - .tmplr.yml - packages/*/package.json - packages/*/patternfly-docs/content/** - packages/*/patternfly-docs/generated/** - key: ${{ runner.os }}-setup-22-${{ secrets.CACHE_VERSION }}-${{ hashFiles('package.json', 'packages/module/package.json') }} - - name: Run build script - run: ./devSetup.sh - shell: bash - if: steps.setup-cache.outputs.cache-hit != 'true' - - uses: actions/setup-node@v4 - with: - node-version-file: '.nvmrc' - - run: corepack enable - - uses: actions/cache@v4 - id: yarn-cache - name: Cache npm deps - with: - path: | - node_modules - **/node_modules - key: ${{ runner.os }}-yarn-22-${{ secrets.CACHE_VERSION }}-${{ hashFiles('yarn.lock') }} - - run: yarn install --immutable - if: steps.yarn-cache.outputs.cache-hit != 'true' - - uses: actions/cache@v4 - id: dist - name: Cache dist - with: - path: | - packages/*/dist - key: ${{ runner.os }}-dist-22-${{ secrets.CACHE_VERSION }}-${{ hashFiles('yarn.lock', 'package.json', 'packages/*/*', '!packages/*/dist', '!packages/*/node_modules') }} - - name: Build dist - run: yarn build - if: steps.dist.outputs.cache-hit != 'true' diff --git a/.github/workflows/check-pr.yml b/.github/workflows/check-pr.yml index fa99007..cb5385c 100644 --- a/.github/workflows/check-pr.yml +++ b/.github/workflows/check-pr.yml @@ -6,3 +6,6 @@ on: jobs: call-build-lint-test-workflow: uses: ./.github/workflows/build-lint-test.yml + secrets: inherit + with: + pr-number: ${{ github.event.number }} diff --git a/.github/workflows/pr-preview.yml b/.github/workflows/pr-preview.yml new file mode 100644 index 0000000..31a6a86 --- /dev/null +++ b/.github/workflows/pr-preview.yml @@ -0,0 +1,47 @@ +name: pr-preview +on: + pull_request_target: + issue_comment: + types: [created] + +jobs: + check-permissions: + uses: patternfly/.github/.github/workflows/check-team-membership.yml@main + secrets: inherit + + deploy-preview: + runs-on: ubuntu-latest + needs: check-permissions + if: needs.check-permissions.outputs.allowed == 'true' + env: + SURGE_LOGIN: ${{ secrets.SURGE_LOGIN }} + SURGE_TOKEN: ${{ secrets.SURGE_TOKEN }} + GH_PR_TOKEN: ${{ secrets.GH_PR_TOKEN }} + GH_PR_NUM: ${{ needs.check-permissions.outputs.pr-number }} + steps: + - uses: actions/checkout@v4 + - run: | + git fetch origin pull/$GH_PR_NUM/head:tmp + git checkout tmp + - uses: actions/setup-node@v4 + with: + node-version-file: '.nvmrc' + - run: corepack enable + - uses: actions/cache@v4 + id: yarn-cache + name: Cache yarn deps + with: + path: | + node_modules + **/node_modules + key: ${{ runner.os }}-yarn-22-${{ secrets.CACHE_VERSION }}-${{ hashFiles('yarn.lock') }} + - run: yarn install --immutable + if: steps.yarn-cache.outputs.cache-hit != 'true' + - run: yarn build + name: Build + - run: yarn build:docs + name: Build docs + - name: Upload docs + uses: patternfly/.github/.github/actions/surge-preview@main + with: + folder: packages/module/public From 942bc3f69576d0483690a2fcdd368012e3fb4a7b Mon Sep 17 00:00:00 2001 From: nicolethoen Date: Wed, 25 Mar 2026 08:18:37 -0400 Subject: [PATCH 2/3] fix type --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 3d25af3..0d21590 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "react", "log", "viewer", - "logviewer", + "logviewer" ], "workspaces": [ "packages/*" From f8471ff16d54e9289a5098ebbb4f193eb40750b8 Mon Sep 17 00:00:00 2001 From: nicolethoen Date: Wed, 25 Mar 2026 08:24:13 -0400 Subject: [PATCH 3/3] update devdeps --- packages/module/package.json | 1 + yarn.lock | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/module/package.json b/packages/module/package.json index 3a7d88b..337cce0 100644 --- a/packages/module/package.json +++ b/packages/module/package.json @@ -47,6 +47,7 @@ "@patternfly/react-table": "^6.0.0", "camel-case": "^3.0.0", "monaco-editor": "^0.34.1", + "puppeteer": "^24.15.0", "react-monaco-editor": "^0.51.0", "resize-observer-polyfill": "^1.5.1", "tslib": "^2.0.0" diff --git a/yarn.lock b/yarn.lock index db8e9ce..0e31237 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4064,6 +4064,7 @@ __metadata: camel-case: "npm:^3.0.0" memoize-one: "npm:^5.1.0" monaco-editor: "npm:^0.34.1" + puppeteer: "npm:^24.15.0" react-monaco-editor: "npm:^0.51.0" resize-observer-polyfill: "npm:^1.5.1" tslib: "npm:^2.0.0"