Better Dependency checking#49
Merged
andreibondarev merged 2 commits intoMay 24, 2023
Merged
Conversation
Collaborator
|
@rickychilcott Thanks Ricky! Any chance that we can add a spec? |
Contributor
Author
|
Sure. There's a lot of stubbing, and I'm actually not sure why |
| @@ -1,23 +1,27 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| VersionError = Class.new(ScriptError) | |||
Collaborator
There was a problem hiding this comment.
We should move this out to a separate errors.rb file soon.
andreibondarev
approved these changes
May 24, 2023
Collaborator
andreibondarev
left a comment
andreibondarev
left a comment
There was a problem hiding this comment.
Thank you for the changes, this is excellent!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There appear to be some cases where our
depends_onhelper doesn't properly determine if a gem has been installed.