Optional dependencies#7
Conversation
|
@andreibondarev check this out. It's kinda cool. I think we could auto-require all development dependencies in the test environment, but there are pros and cons to that. Let me know if you think we should. |
I think that is okay, yes. |
| spec.require_paths = ["lib"] | ||
|
|
||
| spec.add_development_dependency "pry-byebug", "~> 3.10.0" | ||
| spec.add_development_dependency "cohere-ruby", "~> 0.9.3" |
There was a problem hiding this comment.
Do you think we should move ALL of the gems here or maybe leave some core ones under actual deps below?
There was a problem hiding this comment.
I'm not sure. Only the LLMs would feel core enough, but then again, why have cohere if you're using openai?
I could imagine actual core ones being activesupport or other similar gems needed for the plumbing of langchain.
So yes, but in its current state, there might not be any true dependences at all.
There was a problem hiding this comment.
The idea is that you can swap out different LLMs. Ideally, eventually, I think we ought to have a lot more LLM options to pick from.
andreibondarev
left a comment
There was a problem hiding this comment.
@rickychilcott Left you some feedback! THANK YOU for the contribution so far!
|
I ended up calling the method I think this is ready for another review and a thumbs up if we're on the same page to apply this everywhere. |
|
@rickychilcott Would you please upmerge and resolve the conflict (Gemfile.lock I think) and I'll merge this PR in! Thanks again! |
# Conflicts: # Gemfile.lock
|
Done! |
|
Cool! I'm happy to apply this pattern across the Readme and codebase in a separate PR. I might get an opportunity to do so later today or tomorrow. |
|
@rickychilcott Let's do it! I think the examples in |
This PR provides a helper to "require" the gem into the project... but only if it's in already in the Gemfile, otherwise it raises a semi-helpful error message.
In order for this to work, the dependency still needs to be a development dependency (i.e.
spec.add_development_dependency) in the gemspecWorks on #3