Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider exposing get_dpar #1131

Closed
martinmodrak opened this issue Apr 1, 2021 · 2 comments
Closed

Consider exposing get_dpar #1131

martinmodrak opened this issue Apr 1, 2021 · 2 comments

Comments

@martinmodrak
Copy link
Contributor

Maybe I missed something obvious, but if I understand it correctly, when implementing a custom distribution, one has to suppose that dpars are not themselves predicted or manually write code to detect and handle both the "one global value" and "predicted" cases in their posterior_predict_xx, log_lik_xx implementations.

The built-in distributions use get_dpar that seems to handle this distinction automatically. Maybe it could be exposed to users?

If so, then the custom families vignette should be updated to reflect this.

As usual, if you like then I will (at some point :-) be happy to file a pull request implementing this.

@paul-buerkner
Copy link
Owner

paul-buerkner commented Apr 1, 2021 via email

@paul-buerkner
Copy link
Owner

Implemented via #1140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants