Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action for posting artifact diff details to PRs #57

Open
paularmstrong opened this issue May 24, 2019 · 1 comment

Comments

@paularmstrong
Copy link
Owner

commented May 24, 2019

Problem

This repo doesn't have an example of how to get comparison output into its own PRs

Solution

Build a Github action to provide as a comment to each PR, maybe even commit?

@paularmstrong paularmstrong added this to the v1.0.0 milestone May 27, 2019

@paularmstrong paularmstrong added this to To do in 1.0.0 Jun 2, 2019

@DrSensor

This comment has been minimized.

Copy link

commented Jun 15, 2019

Hi,

It's not related to web dev build artifact but you might be interested seeing this PR. I'm currently experimenting the idea of reporting perf result into PR comment using git-notes and github action. The basic idea is from this article which is about storing custom metadata on each commit using git-notes. Basically, every time the PR is sync via push, it will do macro benchmarks then store&push the perf results via git-notes (you can see the data here). I create the reports by querying the notes then feed it to python script (I'm thinking to replace it with vega-cli later). I also create small package called fluent-git which wrap several git-notes operation. However, that project got stalled because there is no project where I can use fluent-git.

Let me know if you have some thought 😉

Additional References
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.