Fixed denormalization skipping of falsy valued ids used in Object schemas

[bsara]

Problem

Currently, if one has an Object schema that contains properties that are mapped to other entities, if the id of one of those mapped entities is 0 or some other falsy value, it will be skipped during denormalization. Seeing that 0 is not an uncommonly used id, it makes sense to allow non-null/non-undefined falsy values to be evaluated rather than skip them as if they were null or undefined.

Here is an example schema that would not currently allow a categoryOwner with an id of 0 to be denormalized, instead, denormalization of categoryOwner would be skipped and the value of categoryOwner would remain 0:

const userSchema = new schema.Entity('users');
const otherSchema = new schema.Entity('others', {
  categoryInfo: {
    categoryOwner: userSchema
  }
});

Solution

The solution here was very simple. There is a check for see if an object's property evaluates to a falsy value; I simply changed this check from if (object[key]) to if (object[key] != null) so that only null and undefined values would be skipped.

I also added a test to Object.test.js for the expected behavior.

TODO

• Add & update tests
• Ensure CI is passing (lint, tests, flow)
• Update relevant documentation

[bsara]

@paularmstrong bumping this to see if it can get some love

[paularmstrong]

Sorry for the slow response here. Looks good to me

[bsara]

@paularmstrong thanks!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.