Skip to content

Fix errors in some browsers such Android #121

Merged
merged 2 commits into from Oct 5, 2012

2 participants

@stanfeldman

I tried to use swig on Android and it fails, then I checked code in google closure compiler
and it said that one comma at the end of array and "extends" declaration without brackets failed.
So I fixed it and now swig works on Android.

@paularmstrong paularmstrong commented on the diff Oct 5, 2012
lib/tags.js
@@ -4,7 +4,7 @@ _.extend(exports, {
autoescape: require('./tags/autoescape'),
block: require('./tags/block'),
'else': require('./tags/else'),
- extends: require('./tags/extends'),
+ "extends": require('./tags/extends'),
@paularmstrong
Owner
paularmstrong added a note Oct 5, 2012

Huh. Didn't realize this one. Words Reserved for Possible Future Use

@paularmstrong
Owner
paularmstrong added a note Oct 5, 2012

Actually, same thing here. JSLint/Nodelint probably need to be updated to warn on these. I'll take that as an action to look into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@paularmstrong paularmstrong commented on the diff Oct 5, 2012
@@ -57,7 +57,7 @@ function createRenderFunc(code) {
// Add this template as a parent to all includes in its scope
'_parents.push(this.id);',
code,
- 'return _output;',
@paularmstrong
Owner
paularmstrong added a note Oct 5, 2012

I wonder why nodelint didn't catch this. I may investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@paularmstrong paularmstrong merged commit 66d5af2 into paularmstrong:master Oct 5, 2012

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.