Fix errors in some browsers such Android #121

Merged
merged 2 commits into from Oct 5, 2012

Conversation

Projects
None yet
2 participants
Contributor

stanfeldman commented Oct 5, 2012

I tried to use swig on Android and it fails, then I checked code in google closure compiler
and it said that one comma at the end of array and "extends" declaration without brackets failed.
So I fixed it and now swig works on Android.

@paularmstrong paularmstrong commented on the diff Oct 5, 2012

lib/tags.js
@@ -4,7 +4,7 @@ _.extend(exports, {
autoescape: require('./tags/autoescape'),
block: require('./tags/block'),
'else': require('./tags/else'),
- extends: require('./tags/extends'),
+ "extends": require('./tags/extends'),
@paularmstrong

paularmstrong Oct 5, 2012

Owner

Actually, same thing here. JSLint/Nodelint probably need to be updated to warn on these. I'll take that as an action to look into.

@paularmstrong paularmstrong commented on the diff Oct 5, 2012

@@ -57,7 +57,7 @@ function createRenderFunc(code) {
// Add this template as a parent to all includes in its scope
'_parents.push(this.id);',
code,
- 'return _output;',
@paularmstrong

paularmstrong Oct 5, 2012

Owner

I wonder why nodelint didn't catch this. I may investigate further.

paularmstrong merged commit 66d5af2 into paularmstrong:master Oct 5, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment