New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle cancellation and returning once headers are ready #11

Merged
merged 24 commits into from Oct 31, 2013

Conversation

Projects
None yet
1 participant
@paulcbetts
Copy link
Owner

paulcbetts commented Oct 27, 2013

This fixes #6 as well as ensuring we fully cancel the network request when asked to. Unfortunately, we are being trolled by mono/mono#792, so this may be tricky.

TODO

  • Handle cancellation on Android
  • Return early on Android
  • Handle cancellation on iOS
  • Make the iOS code not a complete mess
  • Return early on iOS

paulcbetts pushed a commit that referenced this pull request Oct 31, 2013

Paul Betts
Merge pull request #11 from paulcbetts/cancellation
Correctly handle cancellation and returning once headers are ready

@paulcbetts paulcbetts merged commit cf70516 into master Oct 31, 2013

@paulcbetts paulcbetts deleted the cancellation branch Oct 31, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment