GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
I've upgraded the embedded SASS version to 3.2.5. When I get more time to spend on this, I'd like to try to run the unit tests included with sass, but I didn't manage to find the time so far. That said, I am using the build for about 3 weeks without noticing any issues with the generated code (note: I am using the scss syntax only), and version 3.2.5 (or rather all the versions since 3.2.0.alpha) brings a whole bunch of rather cool features.
Few notes on the changes needed
I am not exactly a Ruby guru, and the fixes above can be probably done more elegantly: so any real ruby guru is welcome to change them.
Updated to SASS version 3.2.5
Added one more core test for verification of the new SASS features
Hacked Sass::Util.enum_with_index to work correctly with IronMonkey.
This fixes the incorrect merging of pseudo classes when using the @extend command
Hi @Wintermoose, I'm not really maintaining this anymore. You seem interested though, so you've got commit access now, go ahead and merge this, but try to keep the style consistent.
Feel free to merge the other pull requests too if they look good
Hi, thanks for the offer. I am not quite sure if I am the right person for it though, because I have very little free time to look at it nowadays.
I am also not sure if I dare to merge my pull: it still compiles all I've thrown at it, but the speed becomes quite unacceptable (at least for development). I've chickened out and started using the Mindscape Workbench and while that's not quite instant either, it's probably 10x faster or so.
Without doing any profiling, I am not sure how much of that is in the original code (hard to check, as it won't compile my scss files) and how much is caused by the update: and if that's because of the sass code itself, or my hacks.
I still like the idea of SassAndCoffee, but we would need some (Iron)Ruby guru to have a look at what's going on - unfortunately that's not me.
Merge pull request #62 from Wintermoose/master
Upgrade to SASS 3.2.5
Any chance of this getting incorporated into the latest nuget?
@jgeurts I'll do this next week, right now I'm in Toronto and my Internet sucks
@xpaulbettsx Awesome, thank you!
As a side note, I did run into an issue with the 3.2.5 code where relative paths for imports did not work. I would love to provide a patch, but I'm honestly at a loss for where to track that down. The SassCompiler looks like it sets the working directory in some instances, but I have no real idea how to really debug the ruby code.
@paulcbetts It looks like you merged this in, but I'm not seeing the changes in master. Am I missing something?