From a131deb3979ad58e71ce27ee5909f5e67e962cf9 Mon Sep 17 00:00:00 2001 From: longnghia <41385034+longnghia@users.noreply.github.com> Date: Thu, 5 Dec 2024 15:55:30 +0700 Subject: [PATCH] Fix error "Canvas: trying to draw too large" --- .../java/com/paulcoding/hviewer/ui/component/HImage.kt | 4 ++-- .../java/com/paulcoding/hviewer/ui/page/post/PostPage.kt | 7 ++----- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/com/paulcoding/hviewer/ui/component/HImage.kt b/app/src/main/java/com/paulcoding/hviewer/ui/component/HImage.kt index 202e359..46a6a8e 100644 --- a/app/src/main/java/com/paulcoding/hviewer/ui/component/HImage.kt +++ b/app/src/main/java/com/paulcoding/hviewer/ui/component/HImage.kt @@ -12,7 +12,7 @@ import coil3.request.crossfade import com.paulcoding.hviewer.R @Composable -fun HImage(modifier: Modifier = Modifier, url: String) { +fun HImage(url: String, modifier: Modifier = Modifier) { AsyncImage( model = ImageRequest.Builder(LocalContext.current) .data(url) @@ -22,7 +22,7 @@ fun HImage(modifier: Modifier = Modifier, url: String) { placeholder = painterResource(R.drawable.ic_launcher_foreground), error = painterResource(R.drawable.ic_launcher_foreground), modifier = modifier.fillMaxWidth(), - contentScale = ContentScale.Crop, + contentScale = ContentScale.FillWidth, ) } diff --git a/app/src/main/java/com/paulcoding/hviewer/ui/page/post/PostPage.kt b/app/src/main/java/com/paulcoding/hviewer/ui/page/post/PostPage.kt index 0be549c..59f03b4 100644 --- a/app/src/main/java/com/paulcoding/hviewer/ui/page/post/PostPage.kt +++ b/app/src/main/java/com/paulcoding/hviewer/ui/page/post/PostPage.kt @@ -24,7 +24,6 @@ import androidx.compose.ui.unit.dp import androidx.compose.ui.window.Dialog import androidx.compose.ui.window.DialogProperties import androidx.lifecycle.viewmodel.compose.viewModel -import coil3.compose.AsyncImage import com.paulcoding.hviewer.MainApp.Companion.appContext import com.paulcoding.hviewer.extensions.isScrolledToEnd import com.paulcoding.hviewer.helper.makeToast @@ -116,16 +115,14 @@ fun ImageModal(url: String, dismiss: () -> Unit) { ) { Box( modifier = Modifier - .fillMaxSize() .zoomable( state = zoomableState, onClick = { makeToast("Double click to dismiss") }, onDoubleClick = doubleClickToZoomListener ) ) { - AsyncImage( - model = url, - contentDescription = url, + HImage( + url, modifier = Modifier.align(Alignment.Center), ) }