Blows up when domain has no suffix eg, 'http://www.foo/' #16

Open
ami-navon opened this Issue Jul 27, 2011 · 0 comments

Projects

None yet

1 participant

@ami-navon

Hi,
It seems that Domainatrix.parse() method fails when domain has no suffix eg, 'http://www.foo/'

$ irb

require 'domainatrix'
Domainatrix.parse('http://www.foo/')

NoMethodError: undefined method has_key?' for nil:NilClass
from /Users/ami/.rvm/gems/ruby-1.9.2-head@rails3beta/gems/domainatrix-0.0.10/lib/domainatrix/domain_parser.rb:59:in
block in parse_domains_from_host'

Thanks,
Ami

@fivetwentysix fivetwentysix added a commit that referenced this issue Nov 21, 2011
@fivetwentysix fivetwentysix Resolved Issue #16
No longer raises error when supplied a domain without a valid public suffix.

Signed-off-by: Patrick Ma <pma@novafist.com>
f4960a4
@fivetwentysix fivetwentysix added a commit that referenced this issue Nov 21, 2011
@fivetwentysix fivetwentysix URL will default to the HTTP scheme if no scheme defined.
Solved #16 and #13

Signed-off-by: Patrick Ma <pma@novafist.com>
b0837c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment