Permalink
Commits on Mar 2, 2009
  1. @rtomayko
  2. @rtomayko
Commits on Feb 27, 2009
  1. @rtomayko
  2. @rtomayko
  3. @rtomayko

    Don't allow :session option in body/params arg; misc refactoring

    This changes the parent commit's :session option semantics just
    slightly. The :session option must be passed as part of the options
    Hash -- the body arg is assumed to be params or a POST/PUT body.
    Also, the mapping from :session to HTTP_COOKIE has been switched to
    'rack.session' - mapping it to HTTP_COOKIE doesn't make any sense.
    
    While here, refactor the make_request method to make it more
    obvious that we're really just building up the options Hash for
    MockRequest.
    rtomayko committed Feb 27, 2009
  4. @sr @rtomayko
  5. @rtomayko

    Fix middleware not running when app run as middleware [#161]

    The app's middleware pipeline was ignored when the app itself was
    run as middleware. This was due to the separate call paths for
    middleware vs. endpoint apps. This change makes it so that both
    endpoint and middleware apps are invoked via the same instance
    level #call method.
    
    One potentially confusing aspect of this change is that Base.new now
    returns the head of the app's middleware pipeline. If no middleware
    is used by the app, this will be an instance of the Base class;
    however, if middleware is used, Base.new will return the head of
    the middleware chain leading to the Base instance.
    rtomayko committed Feb 27, 2009
Commits on Feb 25, 2009
  1. @rtomayko

    Better Content-Length handling for HEAD requests

    Responses to HEAD requests _should_ have a Content-Length header
    that's identical to GET requests. When a body is provided by the
    application, set the Content-Length header to the size of the body
    and replace the body with an empty Array; when no body is provided
    by the application in response to a HEAD request, and the
    Content-Length is calculated to be "0", remove the Content-Length
    header entirely to avoid mis-matched values.
    
    The idea here is that it's better to omit the header when we believe
    the Content-Length is not indicative of the same in response to GET
    than to send the Content-Length with a mismatched value. Logic
    taken from Apache and is generally in line with RFC 2616.
    rtomayko committed Feb 25, 2009
  2. @vangberg @rtomayko
Commits on Feb 24, 2009
  1. @rtomayko

    yield the MockRequest to the block before invoking the app [#111]

    sr commented this out during some refactoring but I'd like
    to leave it in for now.
    rtomayko committed Feb 24, 2009
  2. @rtomayko

    Add registered callback for extension modules [#148]

    The "registered" message is sent to extension modules immediately
    after the module is mixed into a Sinatra::Base class. This can be
    used to initialize the class with options, add templates, define
    error handlers, etc.
    rtomayko committed Feb 22, 2009
Commits on Feb 23, 2009
  1. @rtomayko

    Remove disabled compat specs

    rtomayko committed Feb 23, 2009
Commits on Feb 22, 2009
  1. @sr
  2. @sr
  3. @sr @rtomayko

    Test for #head

    sr committed with rtomayko Feb 22, 2009
  4. @sr @rtomayko

    Cosmetic change to test for #follow

    sr committed with rtomayko Feb 22, 2009
  5. @rtomayko
  6. @rtomayko
  7. @rtomayko
  8. @rtomayko
  9. @rtomayko
  10. @sr @rtomayko

    Little refactoring of Sinatra::Test

    sr committed with rtomayko Feb 20, 2009
  11. @sr @rtomayko

    Started test for Sinatra::Test

    sr committed with rtomayko Jan 28, 2009
Commits on Feb 20, 2009
  1. @capotej @rtomayko

    added test for redirect back

    capotej committed with rtomayko Feb 20, 2009
  2. @rtomayko

    Allow helper methods to use blocks in erb views

    Matias Käkelä committed with rtomayko Feb 18, 2009
  3. @Aupajo @rtomayko

    Fixed broken link in README.

    Aupajo committed with rtomayko Feb 18, 2009
  4. @vangberg @rtomayko
Commits on Feb 18, 2009
  1. @bmizerany

    Removing the Sinatra() sugar for now...

    It's apparent the first revision of this has it's
    implications on reloading and other areas and their
    fixes are adding to much LOC.  Let's revisit this
    in time.
    bmizerany committed Feb 18, 2009
Commits on Feb 17, 2009
  1. @rtomayko
  2. @rtomayko

    Fix routes don't match with certain forms of URL encoding [#147]

    We no longer store routes in URL encoded form and unescape the
    PATH_INFO before attempting to match routes. This allows matching
    all variations of encoded characters but does not allow matching
    encoded "/" characters in the PATH_INFO.
    
    See also:
    
    http://sinatra.lighthouseapp.com/projects/9779/tickets/147
    http://groups.google.com/group/sinatrarb/browse_thread/thread/baab6ea877d7c2e4
    rtomayko committed Feb 17, 2009
  3. @rtomayko

    Pin to Rack < 1.0

    There's a variety of things we'll need to change for Rack 1.0,
    including using the new built-in nested params.
    rtomayko committed Feb 17, 2009
  4. @sr @rtomayko

    Add full test coverage for all options

    Test for host option
    Test for port option
    Test for server option
    Test for app_file option
    Test for the root option
    Test for the views option
    Test for the public option
    Test for reload option
    Test for lock option
    Tests for dump_errors, sessions, logging, and static options
    DRY-up options test setup
    Clean up tests for clean_trace options
    Test for run option
    Run options tests with default options
    Enable raise_errors options in test environment
    
    See: http://github.com/sr/sinatra/commits/options/
    sr committed with rtomayko Feb 14, 2009
  5. @sr @rtomayko
  6. @sr @rtomayko
  7. @sam-github @foca