Permalink
Browse files

Don't do "reset master" after restoring, because this makes the backu…

…p of the newly restored instance inconsistent until a full backup is done.

Thanks to Frank O'Dwyer for pointing this out:
http://groups.google.com/group/ec2-on-rails-discuss/browse_thread/thread/e2386df3d329b9a5
  • Loading branch information...
1 parent 221658a commit e493099b86993c044f1b4cdd4ccf333dc9a83265 @pauldowman committed Sep 25, 2009
Showing with 0 additions and 2 deletions.
  1. +0 −2 server/files/usr/local/ec2onrails/bin/restore_app_db
@@ -51,8 +51,6 @@ begin
@s3.retrieve_files("mysql-bin.", @temp_dir)
logs = Dir.glob("#{@temp_dir}/mysql-bin.[0-9]*").sort
logs.each {|log| @mysql.execute_binary_log(log) }
-
- @mysql.execute_sql "reset master" # TODO maybe we shouldn't do this if we're not going to delete the logs from the S3 bucket because this restarts the numbering again
ensure
FileUtils.rm_rf(@temp_dir)
end

0 comments on commit e493099

Please sign in to comment.