format shell script

do_quality_checks.sh

@@ -40,172 +40,170 @@ rootdir=$(dirname $0)
 ASSERT=
 
 ###############################################################################
-
 start_from_scratch() {
-cd $rootdir
-if [ -e Makefile ] ; then
-   make distclean >/dev/null 2>&1
-fi
+  cd $rootdir
+  if [ -e Makefile ] ; then
+    make distclean >/dev/null 2>&1
+  fi
 
 }
 ###############################################################################
 #argument 1 is the compiler
 #argument 2 is the c++ standard
 #argument 3 (optional) is appended to CXXFLAGS
 compile_and_test_standard() {
-start_from_scratch
-/bin/echo -n "using $(basename $1) with standard $2"
-if [ -n "$3" ] ; then
-  echo " (with additional CXXFLAGS $3)"
-else
-  echo ""
-fi
+  start_from_scratch
+  /bin/echo -n "using $(basename $1) with standard $2"
+  if [ -n "$3" ] ; then
+    echo " (with additional CXXFLAGS $3)"
+  else
+    echo ""
+  fi
 
-if ! ./bootstrap.sh >bootstrap.log 2>&1; then
-  echo failed bootstrap - see bootstrap.log
-  exit 1
-fi
-if ! ./configure $ASSERT --enable-warnings CXX=$1 CXXFLAGS="-std=$2 $3" >configure.log 2>&1 ; then
-  echo failed configure - see configure.log
-  exit 1
-fi
-#make sure it compiles
-if ! /usr/bin/time --format=%e --output=time.log make >make.log 2>&1; then
-echo failed make
-exit 1
-fi
-if [ ! -z $MEASURE_COMPILE_TIME ] ; then
-  echo "  compile with $(basename $1) $2 took $(cat time.log) seconds"
-fi
-#check for warnings
-if grep -q "warning" make.log; then
- echo found warning - see make.log
- exit 1
-fi
-#run the tests
-if ! make check >makecheck.log 2>&1 ; then
-   echo failed make check - see makecheck.log
-   exit 1
-fi
+  if ! ./bootstrap.sh >bootstrap.log 2>&1; then
+    echo failed bootstrap - see bootstrap.log
+    exit 1
+  fi
+  if ! ./configure $ASSERT --enable-warnings CXX=$1 CXXFLAGS="-std=$2 $3" >configure.log 2>&1 ; then
+    echo failed configure - see configure.log
+    exit 1
+  fi
+  #make sure it compiles
+  if ! /usr/bin/time --format=%e --output=time.log make >make.log 2>&1; then
+    echo failed make
+    exit 1
+  fi
+  if [ ! -z $MEASURE_COMPILE_TIME ] ; then
+    echo "  compile with $(basename $1) $2 took $(cat time.log) seconds"
+  fi
+  #check for warnings
+  if grep -q "warning" make.log; then
+    echo found warning - see make.log
+    exit 1
+  fi
+  #run the tests
+  if ! make check >makecheck.log 2>&1 ; then
+    echo failed make check - see makecheck.log
+    exit 1
+  fi
 }
 ###############################################################################
 #argument 1 is the compiler
 compile_and_test() {
-#this is the test program to compile, so we know the compiler and standard lib
-#works. clang 4 with c++2a does not.
-/bin/echo -e "#include <iostream>">x.cpp
-#does the compiler understand c++11? That is mandatory.
-if ! $1 -c x.cpp -std=c++11 >/dev/null 2>&1 ; then
-  echo this compiler $1 does not understand c++11
-  return 0
-fi
+  #this is the test program to compile, so we know the compiler and standard lib
+  #works. clang 4 with c++2a does not.
+  /bin/echo -e "#include <iostream>">x.cpp
+  #does the compiler understand c++11? That is mandatory.
+  if ! $1 -c x.cpp -std=c++11 >/dev/null 2>&1 ; then
+    echo this compiler $1 does not understand c++11
+    return 0
+  fi
 
-#loop over all standard flags>=11 and try those which work.
-#use the code words.
-for std in 11 1y 1z 2a ; do
-if ! $1 -c x.cpp -std=c++$std >/dev/null 2>&1 ; then
-  echo compiler does not understand c++$std, skipping this combination.
-else
-    # debug build
-    ASSERT=--enable-assert
-    compile_and_test_standard $1 c++$std "-Og"
+  #loop over all standard flags>=11 and try those which work.
+  #use the code words.
+  for std in 11 1y 1z 2a ; do
+    if ! $1 -c x.cpp -std=c++$std >/dev/null 2>&1 ; then
+      echo compiler does not understand c++$std, skipping this combination.
+    else
+      # debug build
+      ASSERT=--enable-assert
+      compile_and_test_standard $1 c++$std "-Og"
 
-    # release build
-    ASSERT=--disable-assert
-    compile_and_test_standard $1 c++$std "-O2"
-    compile_and_test_standard $1 c++$std "-O3"
-    compile_and_test_standard $1 c++$std "-Os"
-fi
-done
+      # release build
+      ASSERT=--disable-assert
+      compile_and_test_standard $1 c++$std "-O2"
+      compile_and_test_standard $1 c++$std "-O3"
+      compile_and_test_standard $1 c++$std "-Os"
+    fi
+  done
 }
 ###############################################################################
-
 run_with_sanitizer() {
-echo "running with sanitizer (options $1)"
-#find the latest clang compiler
-latestclang=$(ls $(which clang++)* |grep -v libc |sort -g |tail -n1)
-if [ ! -x $latestclang ] ; then
-  echo could not find latest clang $latestclang
-  return 0
-fi
+  echo "running with sanitizer (options $1)"
+  #find the latest clang compiler
+  latestclang=$(ls $(which clang++)* |grep -v libc |sort -g |tail -n1)
+  if [ ! -x $latestclang ] ; then
+    echo could not find latest clang $latestclang
+    return 0
+  fi
 
-start_from_scratch
-./bootstrap.sh >bootstrap.log
-./configure $ASSERT CXX=$latestclang CXXFLAGS="-std=c++1y $1"   >configure.log
-make > make.log 2>&1
-export UBSAN_OPTIONS="halt_on_error=true exitcode=1"
-export ASAN_OPTIONS="halt_on_error=true exitcode=1"
-make check >make-check.log 2>&1
-unset UBSAN_OPTIONS
-unset ASAN_OPTIONS
+  start_from_scratch
+  ./bootstrap.sh >bootstrap.log
+  ./configure $ASSERT CXX=$latestclang CXXFLAGS="-std=c++1y $1"   >configure.log
+  make > make.log 2>&1
+  export UBSAN_OPTIONS="halt_on_error=true exitcode=1"
+  export ASAN_OPTIONS="halt_on_error=true exitcode=1"
+  make check >make-check.log 2>&1
+  unset UBSAN_OPTIONS
+  unset ASAN_OPTIONS
 }
 ###############################################################################
 #This tries to mimick how the debian package is built
 run_with_debian_buildflags() {
-echo "running with buildflags from debian dpkg-buildflags"
-if ! which dpkg-buildflags >/dev/null  ; then
-  echo dpkg-buildflags not found - skipping
-  return 0
-fi
-start_from_scratch
-./bootstrap.sh >bootstrap.log
-eval $(DEB_BUILD_MAINT_OPTIONS="hardening=+all qa=+all,-canary reproducible=+all" dpkg-buildflags --export=sh)
-./configure  >configure.log
-make > make.log 2>&1
-#check for warnings
-if grep -q "warning" make.log; then
- echo "found warning(s) - see make.log"
- exit 1
-fi
-make check >make-check.log 2>&1
+  echo "running with buildflags from debian dpkg-buildflags"
+  if ! which dpkg-buildflags >/dev/null  ; then
+    echo dpkg-buildflags not found - skipping
+    return 0
+  fi
+  start_from_scratch
+  ./bootstrap.sh >bootstrap.log
+  eval $(DEB_BUILD_MAINT_OPTIONS="hardening=+all qa=+all,-canary reproducible=+all" dpkg-buildflags --export=sh)
+  ./configure  >configure.log
+  make > make.log 2>&1
+  #check for warnings
+  if grep -q "warning" make.log; then
+    echo "found warning(s) - see make.log"
+    exit 1
+  fi
+  make check >make-check.log 2>&1
 
-#restore the build environment
-for flag in $(dpkg-buildflags  |cut -f1 -d=) ; do
-  unset $flag
-done 
+  #restore the build environment
+  for flag in $(dpkg-buildflags  |cut -f1 -d=) ; do
+    unset $flag
+  done 
 }
 ###############################################################################
 run_with_libcpp() {
-latestclang=$(ls $(which clang++)* |grep -v libc|sort -g |tail -n1)
-if [ ! -x $latestclang ] ; then
-  echo could not find latest clang - skipping test with libc++
-  return 0
-fi
-#make a test program to make sure it works.
-echo "#include <iostream>
-int main() { std::cout<<\"libc++ works!\";}" >x.cpp
-if ! $latestclang -std=c++11 -stdlib=libc++ -lc++abi x.cpp >/dev/null 2>&1 && [ -x ./a.out ] && ./a.out ; then
-  echo "$latestclang could not compile with libc++ - perhaps uninstalled."
-  return 0
-fi
-#echo using $latestclang with libc++
-compile_and_test_standard $latestclang c++11 "-stdlib=libc++ -D_LIBCPP_DEBUG=1"
+  latestclang=$(ls $(which clang++)* |grep -v libc|sort -g |tail -n1)
+  if [ ! -x $latestclang ] ; then
+    echo could not find latest clang - skipping test with libc++
+    return 0
+  fi
+  #make a test program to make sure it works.
+  echo "#include <iostream>
+  int main() { std::cout<<\"libc++ works!\";}" >x.cpp
+  if ! $latestclang -std=c++11 -stdlib=libc++ -lc++abi x.cpp >/dev/null 2>&1 && [ -x ./a.out ] && ./a.out ; then
+    echo "$latestclang could not compile with libc++ - perhaps uninstalled."
+    return 0
+  fi
+  #echo using $latestclang with libc++
+  compile_and_test_standard $latestclang c++11 "-stdlib=libc++ -D_LIBCPP_DEBUG=1"
 }
 ###############################################################################
 
 verify_packaging() {
-#make sure the packaging works as intended.
- echo "trying to make a tar ball for release and building it..."
- log="$(pwd)/packagetest.log"
- ./bootstrap.sh >$log
- ./configure  >>$log
+  #make sure the packaging works as intended.
+  echo "trying to make a tar ball for release and building it..."
+  log="$(pwd)/packagetest.log"
+  ./bootstrap.sh >$log
+  ./configure  >>$log
 
- touch dummy
- make dist  >>$log
- TARGZ=$(find "$(pwd)" -newer dummy -name "rdfind*gz" -type f |head -n1)
- temp=$(mktemp -d)
- cp "$TARGZ" "$temp"
- cd "$temp"
- tar xzf $(basename "$TARGZ")  >>$log
- cd $(basename "$TARGZ" .tar.gz)
- ./configure --prefix=$temp  >>$log
- make  >>$log
- make check  >>$log
- make install  >>$log
- $temp/bin/rdfind --version   >>$log
- #coming here means all went fine, go back to the source dir.
- cd $(dirname "$TARGZ")
- rm -rf "$temp"
+  touch dummy
+  make dist  >>$log
+  TARGZ=$(find "$(pwd)" -newer dummy -name "rdfind*gz" -type f |head -n1)
+  temp=$(mktemp -d)
+  cp "$TARGZ" "$temp"
+  cd "$temp"
+  tar xzf $(basename "$TARGZ")  >>$log
+  cd $(basename "$TARGZ" .tar.gz)
+  ./configure --prefix=$temp  >>$log
+  make  >>$log
+  make check  >>$log
+  make install  >>$log
+  $temp/bin/rdfind --version   >>$log
+  #coming here means all went fine, go back to the source dir.
+  cd $(dirname "$TARGZ")
+  rm -rf "$temp"
 }
 ###############################################################################
 
@@ -217,11 +215,11 @@ if which g++ >/dev/null ; then
   for COMPILER in $(ls $(which g++)* |grep -v libc); do
     inode=$(stat --dereference --format=%i $COMPILER)
     if grep -q "^$inode\$" inodes_for_tested_compilers.txt ; then
-       echo skipping this compiler $COMPILER - already tested
+      echo skipping this compiler $COMPILER - already tested
     else
       #echo trying gcc $GCC:$($GCC --version|head -n1)
-       echo $inode >>inodes_for_tested_compilers.txt
-       compile_and_test $COMPILER
+      echo $inode >>inodes_for_tested_compilers.txt
+      compile_and_test $COMPILER
     fi
   done
 fi
@@ -231,11 +229,11 @@ if which clang++ >/dev/null ; then
   for COMPILER in $(ls $(which clang++)* |grep -v libc); do
     inode=$(stat --dereference --format=%i $COMPILER)
     if grep -q "^$inode\$" inodes_for_tested_compilers.txt ; then
-       echo skipping this compiler $COMPILER - already tested
+      echo skipping this compiler $COMPILER - already tested
     else
       #echo trying gcc $GCC:$($GCC --version|head -n1)
-       echo $inode >>inodes_for_tested_compilers.txt
-       compile_and_test $COMPILER
+      echo $inode >>inodes_for_tested_compilers.txt
+      compile_and_test $COMPILER
     fi
   done
 fi