New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context, User: deprecate `validateCredentials` in `UserElement` classes. #220

Merged
merged 1 commit into from Oct 6, 2018

Conversation

Projects
None yet
1 participant
@paulgibbs
Copy link
Owner

paulgibbs commented Oct 6, 2018

Description

Remove validateCredentials methods in UserElement classes. This attempted to compare passwords on user objects.

Methods will be removed in 4.0.0.

Related issue

See #155

Motivation and context

I've decided I do not like behaviour that cannot be specific to all drivers, unless there is a strong reason, and I do not think this has it. I have been skeptical of the benefit of trying to compare user passwords in this method, so I am going to rip it out.

How has this been tested?

Not locally. :D

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Context, User: deprecate `validateCredentials` in `UserElement` class…
…es for all drivers.

Methods will be removed in 4.0.0.

See #155

@paulgibbs paulgibbs merged commit c5ce691 into master Oct 6, 2018

1 check passed

license/cla Contributor License Agreement is signed.
Details

@paulgibbs paulgibbs deleted the remove-validatecredentials-method branch Oct 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment