Fix cropping on retina displays #65

Merged
merged 1 commit into from Feb 19, 2014

Conversation

Projects
None yet
2 participants
@herrstucki
Contributor

herrstucki commented Feb 12, 2014

Converts the crop rect to backing store coordinates, so it works properly when the main display is a retina display. Thanks @paulhammond for pointing in the right direction!

Fixes #64

@paulhammond

This comment has been minimized.

Show comment Hide comment
@paulhammond

paulhammond Feb 18, 2014

Owner

Awesome! As I mentioned in #64 I don’t have a retina mac, so I’ve asked a friend for some help testing this before merging. We’ll land it soon.

Owner

paulhammond commented Feb 18, 2014

Awesome! As I mentioned in #64 I don’t have a retina mac, so I’ve asked a friend for some help testing this before merging. We’ll land it soon.

paulhammond added a commit that referenced this pull request Feb 19, 2014

Merge pull request #65 from herrstucki/fix-retina
Fix cropping on retina displays

@paulhammond paulhammond merged commit f40e6dd into paulhammond:master Feb 19, 2014

@paulhammond

This comment has been minimized.

Show comment Hide comment
@paulhammond

paulhammond Feb 19, 2014

Owner

All the tests came back great - thanks for taking the time to fix this.

Owner

paulhammond commented Feb 19, 2014

All the tests came back great - thanks for taking the time to fix this.

@herrstucki herrstucki deleted the herrstucki:fix-retina branch Feb 21, 2014

@herrstucki

This comment has been minimized.

Show comment Hide comment
@herrstucki

herrstucki Feb 21, 2014

Contributor

Great, thanks! BTW, do you have any plans when to release the next version? The last tagged version (which is the one you get when installing with Homebrew) is missing quite a few features.

Contributor

herrstucki commented Feb 21, 2014

Great, thanks! BTW, do you have any plans when to release the next version? The last tagged version (which is the one you get when installing with Homebrew) is missing quite a few features.

@paulhammond

This comment has been minimized.

Show comment Hide comment
@paulhammond

paulhammond Feb 21, 2014

Owner

Good idea. I had hoped to fix a couple more issues before 0.7, but I guess they can just wait until 0.8. I'll do a release sometime early next week!

Owner

paulhammond commented Feb 21, 2014

Good idea. I had hoped to fix a couple more issues before 0.7, but I guess they can just wait until 0.8. I'll do a release sometime early next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment