Css3please upgrades #82

merged 7 commits into from Jan 22, 2012


None yet
2 participants

uxder commented Jan 19, 2012

Hi @paulirish

A few upgrade for your consideration. Please feel free to merge, cherrypick or discard entirely. I haven't tested in all browsers but for the most part, it's working fine.

Changes include:

  1. Added css3 scale.
    Tested in Chrome 16, Safari 5.1.2, FF9, IE9.

Note that it's not additive in that if you toggle on .box_rotate and then select .box_scale, it won't be rotated and scaled.

  1. Added 3D transforms
    Tested in Chrome 16, Safari 5.1.2.
    Still needs testing in IE10 and FF10 but it should work.

  2. Update to copy. Removed reference to text-shadow coming soon because I see that it is already there.


paulirish commented Jan 19, 2012

Nice!! can you put transform style on the right of rotateY like i did with css columns?
also plz add a changelog entry for these changes (and credit yo'self!!)

this is great.


paulirish commented Jan 19, 2012

also. you're now a repo collab so you can commit directly. great stuff from you so far. :)


uxder commented Jan 19, 2012

Awesome! I'm in transit today so I'll make the updates in the next few days.


uxder commented Jan 22, 2012

Hi Paul,

Okay made the updates and it should be ready to merge.

I might have a few more additions but as a collab, what are the ground rules for making commits? Should I just commit directly to master or do you want me to branch and still make pull requests so you can review before merging to master?




paulirish commented Jan 22, 2012

i'd love if you just committed straight to master. unless your ideas are crazy, it's good to have them in by default. :)

paulirish added a commit that referenced this pull request Jan 22, 2012

@paulirish paulirish merged commit 9b27ebd into paulirish:master Jan 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment