Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect with toString #11

Merged
merged 1 commit into from Feb 1, 2018
Merged

Conversation

JoelEinbinder
Copy link
Contributor

Found you!

Copy link
Owner

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this with headless:false and it still reports true, so it doesnt appear to detect headlessness

@JoelEinbinder
Copy link
Contributor Author

It detects protocol

@paulirish
Copy link
Owner

oh boy.

@antoinevastel
Copy link
Collaborator

There is the same problem with navigator.webdriver that is also present in non headless mode. It depends if the goal is to detect only Chrome headless, or more globally automated Chrome.

@paulirish paulirish merged commit 8a83324 into paulirish:master Feb 1, 2018
@paulirish
Copy link
Owner

paulirish commented Feb 1, 2018

There is the same problem with navigator.webdriver that is also present in non headless mode. It depends if the goal is to detect only Chrome headless, or more globally automated Chrome.

@antoinevastel Good call. I added some comments on this one and webdriver to describe that they are adjacent detects: a6a2c89

Also fwiw, the navigator.webdriver object is created if either --headless or --enable-automation is provided: https://cs.chromium.org/chromium/src/content/child/runtime_features.cc?type=cs&q=f:runtime_features.cc+WebRuntimeFeatures::EnableAutomationControlled&sq=package:chromium&l=147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants