New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chokidar causes VS Code extensions crashes on VS Code Insiders v1.31 #787
Comments
The |
Hi, I am using v2.1.0 with fsevents 1.2.7 in my VSCode extension and this still causes the extension to crash in VSCode 1.32.3 on OSX. See christianvoigt/argdown#104 How far away is the release of 3.0.0? |
I just checked again and there seems to be an issue with the update process in VSCode. Even though VSCode shows me I have installed the new version of my extension, the fsevents error thrown shows it is still trying to run the old version. So this is not an issue of Chokidar 2.1.0. Sorry for bothering you. |
Still not work with chokidar@2.1.5 |
Try 3.0-master. |
@paulmillr chokidar 3.0.0 works fine, thanks a lot! |
Great! |
Describe the bug
All VS Code extensions that are using Chokidar in their dependencies crashes on new VS Code Insiders version, that to be release approximately in February.
Versions (please complete the following information):
To Reproduce
Expected behavior
VS Code extensions that are using Chokidar is not crashes with new VS Code Insiders(1.31-insiders) version.
Additional context
This issue was investigated already and the problems is in
fsevents
package, that have some issues with Electron 3 (Node.js 10.2.0) that VS Code 1.31 is using under the hood. As described in this issuefsevents@1.2.4
have no such problems.So it looks like Chokidar is needed to be bumped
fsevents
to 1.2.4 version to be able to work with new Electron and VS Code versions without any errors.The text was updated successfully, but these errors were encountered: