Survive ENOENTs (by ignoring new paths) #33

Merged
merged 2 commits into from Jan 6, 2013

Conversation

Projects
None yet
2 participants
Contributor

kmayer commented Dec 30, 2012

Perhaps not the ideal solution, but at least the caller doesn't die.
#16 (also vojtajina/testacular#265)

There is also a pending test (since I too am not sure what to do) regarding what happens when the item finally appears (is it a file or directory?).

@kmayer kmayer Survive ENOENTs (by ignoring new paths)
#16 (also vojtajina/testacular#265)

There is a pending test (since I too am not sure what to do) regarding what happens when the item finally appears (is it a file or directory?).
e8eb6a5

@paulmillr paulmillr commented on an outdated diff Dec 31, 2012

src/index.coffee
@@ -176,6 +176,7 @@ exports.FSWatcher = class FSWatcher extends EventEmitter
# Get the canonicalized absolute pathname.
fs.realpath item, (error, path) =>
+ return if error && error.code == 'ENOENT'
@paulmillr

paulmillr Dec 31, 2012

Owner

use and and isnt instead of && & == as it’s idiomatic coffee

Owner

paulmillr commented Dec 31, 2012

thanks. could you do the one change and we can merge?

Contributor

kmayer commented Dec 31, 2012

Sure.

Sent from my iPad

On Dec 30, 2012, at 4:35 PM, Paul Miller notifications@github.com wrote:

thanks. could you do the one change and we can merge?


Reply to this email directly or view it on GitHub.

@kmayer kmayer Use 'and' instead of '&&'
to be more coffee-like
b75779d

paulmillr merged commit 4a5aae4 into paulmillr:master Jan 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment