Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fsevents to 0.2.0 #99

Merged
merged 1 commit into from Feb 12, 2014
Merged

Upgrade fsevents to 0.2.0 #99

merged 1 commit into from Feb 12, 2014

Conversation

quicksnap
Copy link
Contributor

I realize this may have wide-reaching implications, but there are some good bug fixes in fsevents 0.2.0.

Would it be possible to merge this in? I've had to fork chokidar and do some shrinkwrap juggling to get a build working on certain OSX versions.

paulmillr added a commit that referenced this pull request Feb 12, 2014
Upgrade fsevents to 0.2.0
@paulmillr paulmillr merged commit 7f94650 into paulmillr:master Feb 12, 2014
@paulmillr
Copy link
Owner

Thank you!

@quicksnap
Copy link
Contributor Author

Thanks so much! I'm curious about when the next patch version bump would be. Am hoping to get it merged into karma eventually.

Thanks again!

@paulmillr
Copy link
Owner

I think I will release new Choki this week

@paulmillr
Copy link
Owner

Can you test it within your projects?

@es128
Copy link
Collaborator

es128 commented Feb 12, 2014

@paulmillr Obviously I haven't had time to address this yet, but something like #92 (comment) should probably be prepared for the next release (i.e. stop trying to install fsevents automatically, but provide setup scripts and clear instructions to allow users to make the choice)

@quicksnap
Copy link
Contributor Author

@paulmillr it didn't cause any issues with our project, but the bugfix in fsevents didn't help us.

As for #92, I am affected by that as well; the extraneous packages cause the shrinkwrap issue, and I need to manually delete the node_modules folder from chokidar before running the command to generate a shrinkwrap.

Thanks for merging it in, though--I'll open a PR on karma once the patch version bumps!

taratatach pushed a commit to taratatach/chokidar that referenced this pull request Oct 2, 2023
Ensure bundled dependencies are staged cleanly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants