Improve #cell argument parsing to distinguish between multiple args and a single arg #9

Merged
merged 1 commit into from Aug 22, 2012

Conversation

Projects
None yet
3 participants
@paulspringett
Owner

paulspringett commented Aug 22, 2012

No description provided.

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Aug 22, 2012

This pull request passes (merged cfb2813 into 5cb0d30).

This pull request passes (merged cfb2813 into 5cb0d30).

@paulspringett

This comment has been minimized.

Show comment Hide comment
@paulspringett

paulspringett Aug 22, 2012

Owner

@brendon I believe this should resolve your outstanding issue in #8

Now, whenever you call csv.cell with 2 arguments, that second argument is set as the cell value, even if it is (or evalutes to) nil

Owner

paulspringett commented Aug 22, 2012

@brendon I believe this should resolve your outstanding issue in #8

Now, whenever you call csv.cell with 2 arguments, that second argument is set as the cell value, even if it is (or evalutes to) nil

paulspringett added a commit that referenced this pull request Aug 22, 2012

Merge pull request #9 from paulspringett/stricter-cell-argument-parsing
Improve #cell argument parsing to distinguish between multiple args and a single arg

@paulspringett paulspringett merged commit 44d0519 into master Aug 22, 2012

1 check passed

default The Travis build passed
Details
@paulspringett

This comment has been minimized.

Show comment Hide comment
@paulspringett

paulspringett Aug 22, 2012

Owner

@brendon I've released version 0.2.0 which should fix your outstanding issue in #8

Owner

paulspringett commented Aug 22, 2012

@brendon I've released version 0.2.0 which should fix your outstanding issue in #8

@brendon

This comment has been minimized.

Show comment Hide comment
@brendon

brendon Aug 25, 2012

Thanks Paul, that's really great :) Good to close off that edge case as I think it could have caught others out, and it's very difficult to figure out the cause without looking at the code :)

Have a great day! :)

brendon commented Aug 25, 2012

Thanks Paul, that's really great :) Good to close off that edge case as I think it could have caught others out, and it's very difficult to figure out the cause without looking at the code :)

Have a great day! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment