Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the right type when calling ykpiv_get_serial (C.uint32_t vs C.uint) #27

Merged
merged 1 commit into from Mar 17, 2020

Conversation

@LouisBrunner
Copy link
Contributor

LouisBrunner commented Mar 17, 2020

When compiling under ARM, I run into an issue because ykpiv_get_serial is being called with the wrong type: pault.ag/go/ykpiv/ykpiv.go:207: cannot use &serial (type *C.uint) as type *C.uint32_t in argument to func literal
This PR fixes that issue by using the expected type (https://github.com/Yubico/yubico-piv-tool/blob/master/lib/ykpiv.h#L209).

Copy link
Owner

paultag left a comment

Amazing thank you!

@paultag paultag merged commit 0005278 into paultag:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.