New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package aliases in command list (PRC) #3

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@jjatria

jjatria commented Aug 2, 2017

The commands method in App::CLI::Helper does not include the list of command aliases. This seems counter intuitive.

This patch adds the command aliases to the list returned by commands.

@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Aug 8, 2017

Owner

As with #2 how did you test this? Also, your comment in the PR would also be really handy in the commit message as it adds valuable information about your reasoning for the patch. I'll add it to the log message when I merge the PR. Other than that, it looks good. I really like the ideas behind your patches and that they make the dist's usage easier for the user.

Owner

paultcochrane commented Aug 8, 2017

As with #2 how did you test this? Also, your comment in the PR would also be really handy in the commit message as it adds valuable information about your reasoning for the patch. I'll add it to the log message when I merge the PR. Other than that, it looks good. I really like the ideas behind your patches and that they make the dist's usage easier for the user.

@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Aug 12, 2017

Owner

Merged in 08d620b; many thanks!

Owner

paultcochrane commented Aug 12, 2017

Merged in 08d620b; many thanks!

@jjatria jjatria deleted the jjatria:alias-in-commands branch Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment