Update version #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…values found in '', which is the real need.
… load files or variables.
…packed_top which recursively replaces the values found in the '' Array with their value from the objects array.
…oops progrmatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I came across your gem as I was needing to handle NSKeyedArchiver data in one of my repositories and wanted to help bring it up to date. The changes in the PR bring the Gemfile much further into 2020 and particularly support the latest version of CFPropertyList.
I saw your issue that was waiting on changes to CFPropertyList and believe I have implemented everything necessary for this to be closed. Of note, I removed
unpacked_objectsand instead made thisunpacked_top, since I believe what you really wanted to accomplish was to be able to use a given key in the NSKeyedArchive to get the data it pointed to.Of note, these are breaking changes, so I have incremented the major version of the gem to 1. The specific breaking change is this initializer now supports the same arguments that CFPropertyList does,
:fileand:data. I needed to use this on data which I was pulling out of SQLite databases, so having to write to disk in order to make a new KeyedArchive was not appealing.Fixes #1.