New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Крэш: flylinkdc!Transfer::getPos (Очередь закачек) #1338

Open
pavel-pimenov opened this Issue Aug 25, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@pavel-pimenov
Copy link
Owner

pavel-pimenov commented Aug 25, 2015

From masteral...@googlemail.com on September 20, 2013 12:47:11

Переименовывал и перемещал папки в очереди закачек, затем закрыл окно очереди и нажал снова его открыть. В итоге - флай упал.

Дамп на c-s: https://www.crash-server.com/UploadedReport.aspx?DumpID=804334

Original issue: http://code.google.com/p/flylinkdc/issues/detail?id=1301

@pavel-pimenov

This comment has been minimized.

Copy link
Owner

pavel-pimenov commented Aug 25, 2015

From Pavel.Pimenov@gmail.com on September 20, 2013 03:55:40

В этом месте много крашей
падаем на (*i)->getPos()
Вероятно коллекция downloads меняется где-то без защиты критической секцией.
Вечером подумаю что можно тут сделать.

// [+] IRainman fix.
void QueueItem::getChunksVisualisation(vector<pair<Segment, Segment>>& p_runnigChunksAndDownloadBytes, vector& p_doneChunks) const
{
SharedLock l(cs); // [+] IRainman fix.

p_runnigChunksAndDownloadBytes.reserve(downloads.size()); // [!] IRainman fix done: [9] https://www.box.net/shared/9ccc91535264c1609a1e for (auto i = downloads.cbegin(); i != downloads.cend(); ++i)
{
    p_runnigChunksAndDownloadBytes.push_back(make_pair((*i)->getSegment(), Segment((*i)->getStartPos(), (*i)->getPos()))); // https://www.box.net/shared/1004787fe85503e7d4d9 }
p_doneChunks.reserve(done.size());
for (auto i = done.cbegin(); i != done.cend(); ++i)
{
    p_doneChunks.push_back(*i);
}

}

Status: Accepted
Owner: Pavel.Pimenov@gmail.com
Cc: a.rain...@gmail.com

@pavel-pimenov

This comment has been minimized.

Copy link
Owner

pavel-pimenov commented Aug 25, 2015

From Pavel.Pimenov@gmail.com on September 20, 2013 07:42:14

Status: Started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment