Skip to content

FIX: Cache valid directs and only allow one type in a template #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 31, 2022
Merged

FIX: Cache valid directs and only allow one type in a template #176

merged 6 commits into from
Jan 31, 2022

Conversation

@angusmcleod
Copy link
Member

@angusmcleod angusmcleod commented Jan 31, 2022

No description provided.

@angusmcleod angusmcleod marked this pull request as ready for review January 31, 2022 07:41
@fzngagan
Copy link
Contributor

fzngagan commented Jan 31, 2022

  1. Saving the wizard with Users directed to wizard after signup. enabled on the same setting twice returns an error.
  2. Template validation error are not displayed on frontend. Attempted fix in FEATURE: validate liquid templates on wizard save #156

@angusmcleod angusmcleod changed the title Cache valid directs and only allow one type in a template FIX: Cache valid directs and only allow one type in a template Jan 31, 2022
@fzngagan fzngagan merged commit 5e5b5e6 into main Jan 31, 2022
@fzngagan fzngagan deleted the improve_after_x_features branch January 31, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@angusmcleod @fzngagan