Skip to content

FIX: dropdown content assignment should be allowed to be set to "text" #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 3, 2022
Merged

FIX: dropdown content assignment should be allowed to be set to "text" #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3169c08
BUGFIX: assignment does not need mapping
angusmcleod Mar 3, 2022
71af94c
Version bump
angusmcleod Mar 3, 2022
cb1054b
FIX: output text for dropdown should not be possible
angusmcleod Mar 3, 2022
caf2333
Bump coverage
angusmcleod Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/javascripts/discourse/components/wizard-custom-field.js.es6
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ export default Component.extend(UndoChanges, {
if (this.isDropdown) {
options.wizardFieldSelection = "key,value";
options.userFieldOptionsSelection = "output";
options.textSelection = "key,value,output";
options.inputTypes = "conditional,association,assignment";
options.textSelection = "key,value";
options.inputTypes = "association,conditional,assignment";
options.pairConnector = "association";
options.keyPlaceholder = "admin.wizard.key";
options.valuePlaceholder = "admin.wizard.value";
Expand Down
2 changes: 1 addition & 1 deletion coverage/.last_run.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"result": {
"line": 92.52
"line": 92.87
}
}
9 changes: 0 additions & 9 deletions lib/custom_wizard/builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,6 @@ def append_field(step, step_template, field_template, build_opts)
end
end

if content[:type] == 'assignment' && field_template['type'] === 'dropdown'
content[:result] = content[:result].map do |item|
{
id: item,
name: item
}
end
end

params[:content] = content[:result]
end
end
Expand Down
2 changes: 1 addition & 1 deletion plugin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true
# name: discourse-custom-wizard
# about: Create custom wizards
# version: 1.18.2
# version: 1.18.3
# authors: Angus McLeod
# url: https://github.com/paviliondev/discourse-custom-wizard
# contact emails: angus@thepavilion.io
Expand Down