Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ics requires a parameter #44

Closed
niccokunzmann opened this issue Feb 18, 2019 · 7 comments · Fixed by #68
Closed

ics requires a parameter #44

niccokunzmann opened this issue Feb 18, 2019 · 7 comments · Fixed by #68

Comments

@niccokunzmann
Copy link
Contributor

@niccokunzmann niccokunzmann commented Feb 18, 2019

I would like to use your software to display calendar events and subscribe to the ICS feed.

I tool an hour searching.

This is expected with a parameter.
https://forum.wilap.de/c/machbar/l/calendar.ics?time_zone=Europe/Berlin
Can we document this somewhere, so other do not need to look that far?
Good would also be not to report that below but to tell the user to add a parameter.
https://forum.wilap.de/c/machbar/l/calendar.ics

Oops

The software powering this discussion forum encountered an unexpected problem. We apologize for the inconvenience.

Detailed information about the error was logged, and an automatic notification generated. We'll take a look at it.

No further action is necessary. However, if the error condition persists, you can provide additional detail, including steps to reproduce the error, by posting a discussion topic in the site's feedback category.

I have been searching in many places. These did it for me:

@niccokunzmann

This comment has been minimized.

Copy link
Contributor Author

@niccokunzmann niccokunzmann commented Feb 18, 2019

This place would need to change.
https://github.com/angusmcleod/discourse-events/blob/6570a75933b63fdb696cc079c9cd0aa0dcecdf8e/plugin.rb#L470
Options:

  • We could use UTC as default time zone.
  • We can create a meaningful error message.

What are your thoughts?

@fzngagan

This comment has been minimized.

Copy link
Collaborator

@fzngagan fzngagan commented Oct 14, 2019

@niccokunzmann Yes we also came across this one recently. I'll take a look in a couple of days.

@niccokunzmann

This comment has been minimized.

Copy link
Contributor Author

@niccokunzmann niccokunzmann commented Oct 14, 2019

@fzngagan

This comment has been minimized.

Copy link
Collaborator

@fzngagan fzngagan commented Oct 15, 2019

I've made a PR here: #68

@niccokunzmann

This comment has been minimized.

Copy link
Contributor Author

@niccokunzmann niccokunzmann commented Oct 15, 2019

This is not done, yet. From an implementation side, it is, see #68. However, this should be documented somewhere. Otherwise, it is not usable.

@fzngagan

This comment has been minimized.

Copy link
Collaborator

@fzngagan fzngagan commented Oct 15, 2019

This is not done, yet. From an implementation side, it is, see #68. However, this should be documented somewhere. Otherwise, it is not usable.

@niccokunzmann, Sure man We'll put that into the O/P on meta. Other than that, do you have any questions about the implementation?

@niccokunzmann

This comment has been minimized.

Copy link
Contributor Author

@niccokunzmann niccokunzmann commented Oct 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.