New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update wunderlist api #23

Merged
merged 20 commits into from Jul 15, 2018

Conversation

Projects
None yet
3 participants
@ArneCL
Contributor

ArneCL commented May 19, 2018

Fixes #12
Fixes issues (Status-Code 500 causes crash) mentioned in MM-Forum

Changes the deprecated wunderlistSDK to a simple API based on request-promise. Eventhough this is not a socket-based solution, it should work fine (as updates are fetched in second-intervalls).
Additionally, this opens up for features of the wunderlist API (like fetching user-avatars..)

@paviro

This comment has been minimized.

Show comment
Hide comment
@paviro

paviro May 20, 2018

Owner

Sadly the Pull Request has some merge conflicts. Could you please resolve them?

Owner

paviro commented May 20, 2018

Sadly the Pull Request has some merge conflicts. Could you please resolve them?

@ArneCL

This comment has been minimized.

Show comment
Hide comment
@ArneCL

ArneCL May 20, 2018

Contributor

While testing, I discovered that even though I updated the fetcher to retrieve the list-revision each interval (and not all todos of the list), the Wunderlist endpoint seems to return a 500 every now and then. I'll add a workaround so the fetcher recovers in this case - which should keep us up and running again... (Please note the WIP = Work in Progress)

Anyways: Also for this Branch Github gives me a green light to merge ...

Contributor

ArneCL commented May 20, 2018

While testing, I discovered that even though I updated the fetcher to retrieve the list-revision each interval (and not all todos of the list), the Wunderlist endpoint seems to return a 500 every now and then. I'll add a workaround so the fetcher recovers in this case - which should keep us up and running again... (Please note the WIP = Work in Progress)

Anyways: Also for this Branch Github gives me a green light to merge ...

@Sispheor

This comment has been minimized.

Show comment
Hide comment
@Sispheor

Sispheor May 29, 2018

So, this module is curently not working until this is merged?

Sispheor commented May 29, 2018

So, this module is curently not working until this is merged?

@ArneCL

This comment has been minimized.

Show comment
Hide comment
@ArneCL

ArneCL May 30, 2018

Contributor

@Sispheor Yes
@paviro this is ready to merge, and has been successfully tested for about a week
EDIT: Please note that all Tasks will be displayed by creation-date... once this is merged, I'll create a fix for that

Contributor

ArneCL commented May 30, 2018

@Sispheor Yes
@paviro this is ready to merge, and has been successfully tested for about a week
EDIT: Please note that all Tasks will be displayed by creation-date... once this is merged, I'll create a fix for that

@ArneCL ArneCL changed the title from WIP Feature/update wunderlist api to Feature/update wunderlist api May 30, 2018

@paviro paviro merged commit ccb23dc into paviro:master Jul 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment