New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escapeCdata: Additional split of substrings "]]>" in CDATA #3452

Open
aka-sps opened this Issue Nov 5, 2018 · 2 comments

Comments

2 participants
@aka-sps

aka-sps commented Nov 5, 2018

See Plugins/XmlExport/xmlexport.cpp escapeCdata.

CDATA ends with "]]>". The substring of str "]]>" requires splitting into different CDATA to prevent unexpected termination of CDATA.

Thank you for your job!

@pawelsalawa

This comment has been minimized.

Owner

pawelsalawa commented Nov 5, 2018

I agree.

For implementation reference (that is - for me, in future) here is mentioning how it should be properly split:
https://stackoverflow.com/a/33291585/2792256

@pawelsalawa pawelsalawa added the bug label Nov 5, 2018

@pawelsalawa pawelsalawa added this to the 3.2.2 milestone Nov 5, 2018

@pawelsalawa

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment