From 913eac5e3dea8125e7a6d47d6398f30d3eb660ad Mon Sep 17 00:00:00 2001 From: Daniel_Cortez Date: Fri, 26 Jul 2019 20:08:52 +0700 Subject: [PATCH 1/2] Revert "disable 239 for native functions" This reverts commit 8948f207ea9c7cef4e7808751a499310d1407148. --- source/compiler/sc3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/compiler/sc3.c b/source/compiler/sc3.c index 993e3589..f87274c3 100644 --- a/source/compiler/sc3.c +++ b/source/compiler/sc3.c @@ -2216,7 +2216,7 @@ static int nesting=0; if (arg[argidx].numdim!=1) { error(48); /* array dimensions must match */ } else { - if (lval.sym==NULL && (arg[argidx].usage & uCONST)==0 && (sym->usage & uNATIVE)==0) + if (lval.sym==NULL && (arg[argidx].usage & uCONST)==0) error(239); if (arg[argidx].dim[0]!=0) { assert(arg[argidx].dim[0]>0); From 3f87cf177352d2fa7f6f793d51cf77c9dbdd62a1 Mon Sep 17 00:00:00 2001 From: Daniel_Cortez Date: Fri, 26 Jul 2019 20:21:36 +0700 Subject: [PATCH 2/2] Update tests for 239 --- source/compiler/tests/const_array_args_and_literals_gh_276.meta | 1 + 1 file changed, 1 insertion(+) diff --git a/source/compiler/tests/const_array_args_and_literals_gh_276.meta b/source/compiler/tests/const_array_args_and_literals_gh_276.meta index 861e659b..1dc0f51a 100644 --- a/source/compiler/tests/const_array_args_and_literals_gh_276.meta +++ b/source/compiler/tests/const_array_args_and_literals_gh_276.meta @@ -7,5 +7,6 @@ const_array_args_and_literals_gh_276.pwn(30) : warning 214: possibly a "const" a const_array_args_and_literals_gh_276.pwn(39) : warning 239: literal array/string passed to a non-const parameter const_array_args_and_literals_gh_276.pwn(40) : warning 239: literal array/string passed to a non-const parameter const_array_args_and_literals_gh_276.pwn(41) : warning 239: literal array/string passed to a non-const parameter +const_array_args_and_literals_gh_276.pwn(60) : warning 239: literal array/string passed to a non-const parameter """ }