Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces double backticks with single backtick in example comments #215

Merged
merged 2 commits into from Oct 22, 2019

Conversation

@adambanker
Copy link
Member

adambanker commented Oct 17, 2019

Replaces double backticks with single backticks in example comments for service functions. This makes it consistent with other R packages.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #215 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   84.22%   84.35%   +0.12%     
==========================================
  Files          50       50              
  Lines        2517     2518       +1     
==========================================
+ Hits         2120     2124       +4     
+ Misses        397      394       -3
Impacted Files Coverage Δ
make.paws/R/docs.R 97.1% <100%> (+0.01%) ⬆️
paws.common/R/config.R 30% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4300181...47ddaa8. Read the comment docs.

@davidkretch

This comment has been minimized.

Copy link
Member

davidkretch commented Oct 21, 2019

I think we want to avoid changing ``` to ``, so I think it should probably be updated to "neither preceded nor followed by a backtick", with a test to that effect.

@davidkretch

This comment has been minimized.

Copy link
Member

davidkretch commented Oct 22, 2019

Looks good to me.

@davidkretch davidkretch merged commit f2c4620 into master Oct 22, 2019
5 checks passed
5 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 84.22%)
Details
codecov/project 84.35% (+0.12%) compared to 4300181
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@davidkretch davidkretch deleted the bug/escape_double_backticks branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.