New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Console LogView cannot view logs if formatted by JSON #1225

Closed
yumix opened this Issue Dec 11, 2016 · 3 comments

Comments

Projects
None yet
6 participants
@yumix

yumix commented Dec 11, 2016

Description


I found that Admin Console Log Viewer show nothing logs formatted by JSON.
I checked other format, e.g. ULF, ODL is work well.

Expected Outcome

I think that Log Viewer should accept all log format supported by Payara Server. e.g. ULF, ODL, JSON.

Current Outcome

Log Viewer shows any logs that format are supported by Payara Server. Certainly, Log Viewer works well in case of ULF and ODL format. But JSON format not work.

loggersettings-to-json
logviewer-json-nothing
(Log File: server.log_2016_111T23-04-03 is JSON format.)

Steps to reproduce (Only for bug reports)

1 -** Start the domain

./asadmin start-domain payaradomain

2 -** Configure an HTTP network listener in the admin console:

Set 'Log File Logging Format' ODL to 'JSON'

3--** Restart the domain

4--**After the restart domain

Log file logging format is already changed to JSON.
Select 'View Log Files' from 'General Information', show Log Viewer but no log entry is listed.

Samples

Please trace to step to reproduce (above) in your environment.

Environment

  • Payara Version: 4.1.1.164
  • Edition: Web
  • JDK Version: Oracle JDK 8 (update 112)
  • Operating System: Windows 10 Professional
@khasunuma

This comment has been minimized.

Show comment
Hide comment
@khasunuma

khasunuma Dec 12, 2016

Contributor

I can reproduce it. But I'm afraid that LogViewer cannot show JSON-formatted logs without more improvement. (I think it's not a bug.)

com.sun.enterprise.server.logging.GFFileHandler.formatter in logging.properties is accepted UniformLogFormatter, ODLLogFormatter or custom formatters. GFFileHandler assumes JSONLogFormatter as a custom formatter and LogViewer cannot show any custom formatters.

If you want to show JSON-formatted logs on Admin Console in the present, I suggest using not LogViewer but RawLogViewer.


I think that it should be treat as an improvement request.

Contributor

khasunuma commented Dec 12, 2016

I can reproduce it. But I'm afraid that LogViewer cannot show JSON-formatted logs without more improvement. (I think it's not a bug.)

com.sun.enterprise.server.logging.GFFileHandler.formatter in logging.properties is accepted UniformLogFormatter, ODLLogFormatter or custom formatters. GFFileHandler assumes JSONLogFormatter as a custom formatter and LogViewer cannot show any custom formatters.

If you want to show JSON-formatted logs on Admin Console in the present, I suggest using not LogViewer but RawLogViewer.


I think that it should be treat as an improvement request.

@mikecroft

This comment has been minimized.

Show comment
Hide comment
@mikecroft

mikecroft Dec 12, 2016

Contributor

Thanks, @khasunuma, you're right, this is an enhancement request. I've created internal issue PAYARA-1270 for the enhancement.

Contributor

mikecroft commented Dec 12, 2016

Thanks, @khasunuma, you're right, this is an enhancement request. I've created internal issue PAYARA-1270 for the enhancement.

@smillidge

This comment has been minimized.

Show comment
Hide comment
@smillidge

smillidge Feb 22, 2018

Contributor

Fixed by #1943

Contributor

smillidge commented Feb 22, 2018

Fixed by #1943

@smillidge smillidge closed this Feb 22, 2018

@fturizo fturizo removed the 2:WithDev label Feb 22, 2018

@OndrejM OndrejM added this to the Payara 5.181 milestone Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment